Make RefStatic and LayoutStatic the same bit #31965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are conceptually the same thing and are always visited together so they don't need to be different flags.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
|
Comparing: dc75782...a595e8a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
approved these changes
Jan 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Refs are basically just fancy Layout Effects. These are conceptually the same thing and are always visited together so they don't need to be different flags. Whenever we disappear/reappear Offscreen content we need to do both Refs and Layout Effects. This is just indicating which phase needs to be visited and these are always the same phase. DiffTrain build for [3b009b4](3b009b4)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Refs are basically just fancy Layout Effects. These are conceptually the same thing and are always visited together so they don't need to be different flags. Whenever we disappear/reappear Offscreen content we need to do both Refs and Layout Effects. This is just indicating which phase needs to be visited and these are always the same phase. DiffTrain build for [3b009b4](3b009b4)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jan 3, 2025
Refs are basically just fancy Layout Effects. These are conceptually the same thing and are always visited together so they don't need to be different flags. Whenever we disappear/reappear Offscreen content we need to do both Refs and Layout Effects. This is just indicating which phase needs to be visited and these are always the same phase. DiffTrain build for [3b009b4](facebook@3b009b4)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jan 3, 2025
Refs are basically just fancy Layout Effects. These are conceptually the same thing and are always visited together so they don't need to be different flags. Whenever we disappear/reappear Offscreen content we need to do both Refs and Layout Effects. This is just indicating which phase needs to be visited and these are always the same phase. DiffTrain build for [3b009b4](facebook@3b009b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs are basically just fancy Layout Effects. These are conceptually the same thing and are always visited together so they don't need to be different flags.
Whenever we disappear/reappear Offscreen content we need to do both Refs and Layout Effects.
This is just indicating which phase needs to be visited and these are always the same phase.