[flags] Delete enableDebugTracing #31780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
Dec 14, 2024
| export const ProfileMode = /* */ 0b0000010; | ||
| export const DebugTracingMode = /* */ 0b0000100; | ||
| export const ProfileMode = /* */ 0b0000010; | ||
| //export const DebugTracingMode = /* */ 0b0000100; // Removed |
There was a problem hiding this comment.
@sebmarkbage @acdlite when we delete a mode, should we shift the bits or is there a good reason to keep the slot (maybe DevTools needs to match up, for example idk)?
There was a problem hiding this comment.
Looks like DevTools use it so probably easiest leave it.
|
Comparing: 0d67cc0...bd07780 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
approved these changes
Dec 14, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unused, even in the one builds that uses it, and we don't plan on landing it in this form.