Optimize method calls w props receiver #31771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
josephsavona
added a commit
that referenced
this pull request
Dec 13, 2024
ghstack-source-id: 6a49070add645384c4b764db4749f829a1992f43 Pull Request resolved: #31771
facebook-github-bot
added
CLA Signed
React Core Team
|
Closes #31763 |
mofeiZ
reviewed
Dec 13, 2024
| @@ -50,26 +50,35 @@ export const FIXTURE_ENTRYPOINT = { | |||
| ```javascript | |||
| import { c as _c } from "react/compiler-runtime"; // @enableJsxOutlining | |||
| function Component(arr) { | |||
There was a problem hiding this comment.
nit: can we rewrite this fixture to destructure props i.e. function Component({ arr })?
mofeiZ
reviewed
Dec 13, 2024
| ``` | ||
|
|
||
| ### Eval output | ||
| (kind: exception) Fixture not implemented |
There was a problem hiding this comment.
nit: could we add a FIXTURE_ENTRYPOINT export here?
[ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Dec 14, 2024
ghstack-source-id: 9c6361d548fa821f900c4a4f25ff7297d6c0b676 Pull Request resolved: #31771
josephsavona
added a commit
that referenced
this pull request
Dec 14, 2024
Redo of #31771 without ghstack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):