[compiler] Support default imports for autodep config #31657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbrown215
force-pushed
the
pr31657
branch
2 times, most recently
from
793dd50 to
3ddbd8e
Compare
mofeiZ
reviewed
Dec 2, 2024
| } else { | ||
| t6 = $[13]; | ||
| } | ||
| useEffectWrapper(t6, [foo]); |
mofeiZ
reviewed
Dec 2, 2024
| ) { | ||
| const moduleTargets = autodepFnConfigs.get(value.binding.module); | ||
| if (moduleTargets != null) { | ||
| const numRequiredArgs = moduleTargets.get('default'); |
There was a problem hiding this comment.
Does it make sense to make default a constant in Environment.ts for grep-ability?
There was a problem hiding this comment.
yea, sounds reasonable to me! I like grep-ability + find-refs-ability
## Summary Drops .current field accesses in inferred dep arrays
## Summary Allows us to add deps for things like `import useWrapperEffect from 'useWrapperEffect'`
jbrown215
added a commit
that referenced
this pull request
Dec 3, 2024
## Summary Drops .current field accesses in inferred dep arrays --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31652). * #31657 * __->__ #31652
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows us to add deps for things like
import useWrapperEffect from 'useWrapperEffect'Stack created with Sapling. Best reviewed with ReviewStack.