[compiler] Support enableRefAsProp in jsx transform #31558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
approved these changes
Nov 15, 2024
Comment on lines
576
to
582
| case 'ref': { | ||
| refProperty = { | ||
| kind: 'ObjectProperty', | ||
| key: {name: 'ref', kind: 'string'}, | ||
| type: 'property', | ||
| place: {...prop.place}, | ||
| }; |
There was a problem hiding this comment.
reusing the object property means reusing the Place instances, which is invalid. let's remove the fallthrough and just assign to both refProperty and push to props with distinct object property values and places
This was referenced Dec 4, 2024
jackpope
added a commit
that referenced
this pull request
Dec 10, 2024
…31726) When supporting ref as prop in #31558, I missed fixing the optimization to pass a spread-props-only props object in without an additional object copy. In the case that we have only a ref along with a spread, we cannot return only the spread object. This results in dropping the ref. In this example ```javascript <Foo ref={ref} {...props} /> ``` The bugged output is: ```javascript { // ... props: props } ``` With this change we now get the correct output: ```javascript { // ... props: {ref: ref, ...props} } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
enableRefAsPropshipped everywhere, the ReactElement implementation on prod puts refs on bothelement.refandelement.props.ref. Here we let therefcase fall through so its now available on props, matching the JSX runtime.