Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Overlapping "message" Bug in Performance Track #31528

Merged
merged 4 commits into from
Nov 14, 2024

Commits on Nov 14, 2024

  1. Save the last committed/interrupted time

    That way we can clamp a new update within the same event which otherwise
    would have en event time before the old render.
    sebmarkbage committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6961241 View commit details
    Browse the repository at this point in the history
  2. Finalize render when root did not complete or suspended with delay

    This is a special case which ends with no on-going renders but also doesn't
    commit. So we need to finalize the render so that we know that we can't.
    
    This should probably be handled more like a suspended yield instead.
    sebmarkbage committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4b3b123 View commit details
    Browse the repository at this point in the history
  3. Reset the event name to "" if we're doing more than one render within…

    … the event
    
    We do this by applying the clamp lazily and not resetting the event info between renders.
    sebmarkbage committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    613a8de View commit details
    Browse the repository at this point in the history
  4. Track current event at the beginning of a scheduled task

    That way we can ignore this event when we log where an update happened.
    sebmarkbage committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d1d95a5 View commit details
    Browse the repository at this point in the history