Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider alternate as a key for componentLogsEntry when inspecting raw fiber instance #31009

Merged
merged 1 commit into from
Sep 24, 2024
+8 −1
Merged

fix: consider alternate as a key for componentLogsEntry when inspecting raw fiber instance #31009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
fix: consider alternate as a key for componentLogsEntry when inspecti… 
…ng raw fiber instance
@hoxyq
hoxyq committed Sep 20, 2024
commit a5b2ad49222c69a0abaaf282bea9ec268cd5f530
9 changes: 8 additions & 1 deletion packages/react-devtools-shared/src/backend/fiber/renderer.js
View file
Original file line number Diff line number Diff line change
@@ -1029,6 +1029,10 @@ export function attach(
if (devtoolsInstance.kind === FIBER_INSTANCE) {
const fiber = devtoolsInstance.data;
componentLogsEntry = fiberToComponentLogsMap.get(fiber);

if (componentLogsEntry === undefined && fiber.alternate !== null) {
componentLogsEntry = fiberToComponentLogsMap.get(fiber.alternate);
}
} else {
const componentInfo = devtoolsInstance.data;
componentLogsEntry = componentInfoToComponentLogsMap.get(componentInfo);
@@ -4248,7 +4252,10 @@ export function attach(
source = getSourceForFiberInstance(fiberInstance);
}

const componentLogsEntry = fiberToComponentLogsMap.get(fiber);
let componentLogsEntry = fiberToComponentLogsMap.get(fiber);
if (componentLogsEntry === undefined && fiber.alternate !== null) {
componentLogsEntry = fiberToComponentLogsMap.get(fiber.alternate);
}

return {
id: fiberInstance.id,