Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Track Tree Base Duration of Virtual Instances #30817

Merged
merged 3 commits into from
Aug 27, 2024
Merged

[DevTools] Track Tree Base Duration of Virtual Instances #30817

merged 3 commits into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. Track the treeBaseDuration of Virtual Instances 

    These don't have their own time since they don't take up any time to render
but they show up in the tree for context. However they never render
themselves. Their base tree time is the base time of their children.
    @sebmarkbage
    sebmarkbage committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    db4d63b View commit details
    Browse the repository at this point in the history

  2. Mention that these didn't client render to clarify 

    We don't track the difference between a virtual instance and a Fiber that
didn't render this update. This might be a bit confusing as to why it didn't
render. I add the word "client" to make it a bit clearer.

But really we should probably have different verbiage here based on it is
a Server Component or something else.
    @sebmarkbage
    sebmarkbage committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b65c514 View commit details
    Browse the repository at this point in the history

  3. Remove idToTreeBaseDurationMap and idToRootMap maps 

    Cloning the Map isn't really all that super fast anyway and it means we
have to maintain the map continuously as we render.

Instead, we can track it on the instances and then walk the instances
to create a snapshot when starting to profile. This isn't as fast but
really fast too and requires less bookkeeping while rendering.
    @sebmarkbage
    sebmarkbage committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3e2119c View commit details
    Browse the repository at this point in the history