Keep value of controlled number fields upon action #30737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This makes sense to me but maybe needs another pair of eyes. I'm not sure this is exhaustive since you can trigger actions and resets in arbitrary way - such as based on a different keystroke. Ideally maybe it would sync it right before resetting. |
sebmarkbage
approved these changes
Aug 19, 2024
|
I don't really like doing it in keypress, that seems too clever given that it's not exhaustive… should we do it in the |
|
Working on another solution with more changes |
|
Opened a new PR with different solution (which I think is more correct) - #30752 |
|
Closing this, as there is a more suitable solution in #30752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, React changes the defaultValue for number fields not on every change, but on blur. The reasons are described in issue #7253.
Now this bug is not reproducible in Chrome. Just to be sure, I checked that it was fixed specifically in Chrome, and not with some React update (I ran React v15.2 in modern Chrome and there were no issues from the task there either).
I extended the
EventPlugin, making the replacement ofdefaultValuenot only on blur, but also on submit (since you can press Enter without leaving the field and the form will be submitted). But I did it specifically on thekeypressevent, so that it works before reset and on the submit itself without a submitter (this is, for example, when callingrequestSubmit()).Added a "
force" option insetDefaultValue, because a numeric field can be in focus (and on submit, the value needs to be changed always).I honestly tried to cover this with tests, but couldn't find a way to trigger submit by simulating a key press...
Fixes #29862
Closes #29862
How did you test this change?
Before fix:
react_number_on_action_before.mp4
After fix:
react_number_on_action_after.mp4