Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity check for #28601 #28604

Closed
wants to merge 2 commits into from
Closed

Sanity check for #28601 #28604

wants to merge 2 commits into from

Conversation

unstubbable
Copy link
Contributor

This is to verify that the test that was added in #28601 does succeed in the CI, when temporarily reverting #28283.

After the CI run, I will close the PR again.

@unstubbable
Add a test for issue facebook#28595
d5cbcd6 
The added test, intended to fail and reproduce the [reported
issue](facebook#28595), unexpectedly
passes in its current state. I see three possible reasons:

1. The bug report could be invalid.
2. How I've structured the test might be insufficient to replicate what
   `ai/rsc` is doing.
3. Something in the test setup could be masking the actual error.
   (Maybe related to fake timers?)

If the problem lies in reason 2 or 3, this test could possibly serve as
a foundation for further investigation.
@unstubbable
Revert "[Flight] Serialize deduped elements by direct reference even …
15fefa1 
…if they suspend (facebook#28283)"

This reverts commit ba5e6a8.
@react-sizebot
Copy link

Comparing: a493901...15fefa1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.84 kB 176.84 kB = 54.92 kB 54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.27 kB 173.27 kB = 54.04 kB 54.04 kB
facebook-www/ReactDOM-prod.classic.js = 594.30 kB 594.30 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 577.56 kB 577.56 kB = 101.48 kB 101.48 kB
test_utils/ReactAllWarnings.js Deleted 66.48 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 141.99 kB 141.61 kB = 32.22 kB 32.04 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js = 143.44 kB 143.04 kB = 31.39 kB 31.24 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 139.71 kB 139.32 kB = 31.60 kB 31.41 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 139.36 kB 138.97 kB = 31.38 kB 31.20 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js = 140.87 kB 140.47 kB = 30.70 kB 30.54 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 137.11 kB 136.73 kB = 31.27 kB 31.10 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 137.07 kB 136.68 kB = 30.79 kB 30.60 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 136.06 kB 135.68 kB = 30.95 kB 30.63 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 135.18 kB 134.80 kB = 30.76 kB 30.58 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 133.62 kB 133.23 kB = 30.26 kB 29.91 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 130.91 kB 130.52 kB = 29.72 kB 29.54 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 120.31 kB 119.92 kB = 27.92 kB 27.81 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 120.31 kB 119.92 kB = 27.92 kB 27.81 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js = 120.94 kB 120.54 kB = 27.09 kB 26.98 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js = 120.94 kB 120.54 kB = 27.09 kB 26.98 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 118.02 kB 117.64 kB = 27.30 kB 27.19 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 118.02 kB 117.64 kB = 27.30 kB 27.19 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 117.67 kB 117.29 kB = 27.04 kB 26.94 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 117.67 kB 117.29 kB = 27.04 kB 26.94 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 116.96 kB 116.58 kB = 27.22 kB 27.11 kB
oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js = 118.37 kB 117.97 kB = 26.41 kB 26.31 kB
oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js = 118.37 kB 117.97 kB = 26.41 kB 26.31 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 115.38 kB 115.00 kB = 26.47 kB 26.36 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 115.38 kB 115.00 kB = 26.47 kB 26.36 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 114.95 kB 114.57 kB = 26.82 kB 26.72 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 114.95 kB 114.57 kB = 26.82 kB 26.72 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 114.89 kB 114.51 kB = 26.66 kB 26.55 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 114.58 kB 114.19 kB = 26.76 kB 26.65 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 114.58 kB 114.19 kB = 26.76 kB 26.65 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 114.30 kB 113.92 kB = 26.32 kB 26.21 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 113.02 kB 112.64 kB = 26.31 kB 26.21 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 113.02 kB 112.64 kB = 26.31 kB 26.21 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js = 112.23 kB 111.84 kB = 25.83 kB 25.72 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 112.13 kB 111.75 kB = 26.08 kB 25.97 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 112.13 kB 111.75 kB = 26.08 kB 25.97 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 111.78 kB 111.39 kB = 26.26 kB 26.16 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 111.46 kB 111.07 kB = 26.19 kB 26.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 110.05 kB 109.67 kB = 25.82 kB 25.72 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 109.22 kB 108.83 kB = 25.50 kB 25.40 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 109.22 kB 108.83 kB = 25.50 kB 25.40 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 109.21 kB 108.82 kB = 25.58 kB 25.47 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 106.80 kB 106.42 kB = 25.02 kB 24.92 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 106.80 kB 106.42 kB = 25.02 kB 24.92 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 106.08 kB 105.69 kB = 24.82 kB 24.71 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 104.73 kB 104.35 kB = 24.47 kB 24.38 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 104.73 kB 104.35 kB = 24.47 kB 24.38 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 104.15 kB 103.76 kB = 24.13 kB 24.03 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 104.15 kB 103.76 kB = 24.13 kB 24.03 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js = 102.07 kB 101.68 kB = 23.64 kB 23.54 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js = 102.07 kB 101.68 kB = 23.64 kB 23.54 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 101.17 kB 100.78 kB = 23.90 kB 23.81 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 101.17 kB 100.78 kB = 23.90 kB 23.81 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 100.85 kB 100.46 kB = 23.84 kB 23.74 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 100.85 kB 100.46 kB = 23.84 kB 23.74 kB
facebook-www/ReactFlightDOMServer-dev.modern.js = 101.90 kB 101.50 kB = 21.16 kB 21.04 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 99.44 kB 99.06 kB = 23.46 kB 23.37 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 99.44 kB 99.06 kB = 23.46 kB 23.37 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 98.60 kB 98.21 kB = 23.24 kB 23.13 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 98.60 kB 98.21 kB = 23.24 kB 23.13 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.92 kB 95.53 kB = 22.65 kB 22.55 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.92 kB 95.53 kB = 22.65 kB 22.55 kB
oss-experimental/react-server/cjs/react-server-flight.development.js = 93.16 kB 92.78 kB = 21.15 kB 20.82 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js = 72.35 kB 71.97 kB = 17.23 kB 17.11 kB
oss-stable/react-server/cjs/react-server-flight.development.js = 72.35 kB 71.97 kB = 17.23 kB 17.11 kB
oss-experimental/react-server/cjs/react-server-flight.production.js = 69.23 kB 68.85 kB = 16.55 kB 16.43 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.js = 59.30 kB 58.91 kB = 14.46 kB 14.34 kB
oss-stable/react-server/cjs/react-server-flight.production.js = 59.30 kB 58.91 kB = 14.46 kB 14.34 kB
test_utils/ReactAllWarnings.js Deleted 66.48 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Generated by 🚫 dangerJS against 15fefa1

@unstubbable
Copy link
Contributor Author

Sanity confirmed, closing.

@unstubbable unstubbable deleted the lazy-node-test-with-revert branch March 21, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unstubbable @react-sizebot @facebook-github-bot