Back out stack starting "[React Sync] [Fizz] Add Component Stacks to onError and onPostpone when in dev mode or during prerenders in prod mode (#27761)"
#27849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`onError` and `onPostpone` when in dev mode or during prerenders in prod mode (facebook#27761)" Summary: Backing out this change since it is the most likely culprit for a significant observed performance regression. Original commit changeset: bf4ae59939dc Original Phabricator Diffs: D52225293, D52290859 Reviewed By: josephsavona, fullstackhacker Differential Revision: D52307383
|
This pull request was exported from Phabricator. Differential Revision: D52307383 |
josephsavona
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Let's fix forward on GitHub (#27850) and just backout internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Backing out this change since it is the most likely culprit for a significant observed performance regression.
Original commit changeset: bf4ae59939dc
Original Phabricator Diffs: D52225293, D52290859
Reviewed By: josephsavona, fullstackhacker
Differential Revision: D52307383