Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure close is called after getRoot in decodeReply #27633

Closed
wants to merge 2 commits into from

Conversation

ztanner
Copy link
Contributor

@ztanner ztanner commented Nov 1, 2023

Summary

decodeReply should be resilient to recieving FormData that doesn't match the expected payload. If formData.get(0) is missing, close should error. However if this is called before getRoot, it won't ever properly reject the promise because getRoot will create a pending chunk that is never resolved.

@facebook-github-bot
Copy link

Hi @ztanner!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@ztanner ztanner closed this Nov 1, 2023
@ztanner ztanner reopened this Nov 1, 2023
@ztanner ztanner marked this pull request as ready for review November 1, 2023 01:12
@ztanner ztanner closed this Nov 1, 2023
@ztanner ztanner deleted the fix/close-root-after-get branch November 4, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants