Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build: use content hash for facebook-react-native build" #27584

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 25, 2023

Reverts #27577.

We also sync React Native OSS bundles which means this didn't work as hoped unless we abandon the commit hash in OSS which seems useful.

@kassens kassens requested review from poteto and hoxyq October 25, 2023 17:29
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 25, 2023
@react-sizebot
Copy link

Comparing: 51ffd35...0acd3c6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.04 kB 175.04 kB = 54.47 kB 54.47 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.17 kB 177.17 kB = 55.15 kB 55.15 kB
facebook-www/ReactDOM-prod.classic.js = 567.61 kB 567.61 kB = 99.94 kB 99.94 kB
facebook-www/ReactDOM-prod.modern.js = 551.47 kB 551.47 kB = 97.04 kB 97.04 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0acd3c6

@devichand1319
Copy link

I've noticed a change in the behavior of the fitBounds function in Leaflet, particularly when using the padding option. This change seems to have occurred since the RC1 release. In earlier versions, such as 0.7.5, the padding worked differently, but in newer versions like 1.0.0-rc.1, the padding appears to be much larger, causing the map to zoom out significantly.

I've also observed this issue when applying the padding to layers containing SVG polygons. Even with very small points, like L.point(0.001, 0.001), the map still zooms out excessively.

This seems like a regression in the fitBounds function, especially from RC1 onward. To address this issue, I would recommend reporting it to the Leaflet project's issue tracker or community forums, as it appears to be an unintended behavior or bug in the library.

@kassens kassens merged commit 97047a8 into main Oct 25, 2023
2 checks passed
@kassens kassens deleted the revert-27577-content-hash branch October 25, 2023 19:07
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
)

Reverts #27577.

We also sync React Native OSS bundles which means this didn't work as
hoped unless we abandon the commit hash in OSS which seems useful.

DiffTrain build for [97047a8](97047a8)
acdlite added a commit to acdlite/next.js that referenced this pull request Oct 26, 2023
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Oct 26, 2023
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…ebook#27584)

Reverts facebook#27577.

We also sync React Native OSS bundles which means this didn't work as
hoped unless we abandon the commit hash in OSS which seems useful.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
)

Reverts #27577.

We also sync React Native OSS bundles which means this didn't work as
hoped unless we abandon the commit hash in OSS which seems useful.

DiffTrain build for commit 97047a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants