Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Cleanup turbopack tests #27552

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Oct 20, 2023

Renames turbopack flight test files. removes tests which are primarily testing internal implemenation behavior of Flight Client itself

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 20, 2023
…y testing internal implemenation behavior of Flight Client itself
@gnoff gnoff force-pushed the cleanup-turbopack-flight-tests branch from 1db4906 to 759ff89 Compare October 20, 2023 00:27
@react-sizebot
Copy link

Comparing: 3a1967b...759ff89

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.94 kB 174.94 kB = 54.44 kB 54.44 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.06 kB 177.06 kB = 55.12 kB 55.12 kB
facebook-www/ReactDOM-prod.classic.js = 567.28 kB 567.28 kB = 99.85 kB 99.85 kB
facebook-www/ReactDOM-prod.modern.js = 551.14 kB 551.14 kB = 96.94 kB 96.94 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 759ff89

@gnoff gnoff merged commit 90172d1 into facebook:main Oct 21, 2023
2 checks passed
@gnoff gnoff deleted the cleanup-turbopack-flight-tests branch October 21, 2023 06:21
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Renames turbopack flight test files. removes tests which are primarily
testing internal implemenation behavior of Flight Client itself
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Renames turbopack flight test files. removes tests which are primarily
testing internal implemenation behavior of Flight Client itself

DiffTrain build for commit 90172d1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants