Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused argument from schedule requestHostCallback #27133

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

tjallingt
Copy link
Contributor

Noticed this argument was left in the cleanup from #27130
It seems to me like it would benefit from being cleaned up too.

@react-sizebot
Copy link

Comparing: 899cb95...46d2901

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.38 kB 164.38 kB = 51.77 kB 51.77 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.79 kB 171.79 kB = 53.99 kB 53.99 kB
facebook-www/ReactDOM-prod.classic.js = 567.40 kB 567.40 kB = 100.10 kB 100.10 kB
facebook-www/ReactDOM-prod.modern.js = 551.20 kB 551.20 kB = 97.26 kB 97.26 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 46d2901

@noahlemen noahlemen merged commit 587ae49 into facebook:main Jul 20, 2023
@noahlemen
Copy link
Member

nice catch! thanks 🙂

github-actions bot pushed a commit that referenced this pull request Jul 20, 2023
Noticed this argument was left in the cleanup from
#27130
It seems to me like it would benefit from being cleaned up too.

DiffTrain build for [587ae49](587ae49)
@tjallingt tjallingt deleted the patch-1 branch March 12, 2024 13:52
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…book#27133)

Noticed this argument was left in the cleanup from
facebook#27130
It seems to me like it would benefit from being cleaned up too.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Noticed this argument was left in the cleanup from
#27130
It seems to me like it would benefit from being cleaned up too.

DiffTrain build for commit 587ae49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants