Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alwaysThrottleRetries flag #26685

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

acdlite
Copy link
Contributor

@acdlite acdlite commented Apr 20, 2023

This puts the change introduced by #26611 behind a flag until Meta is able to roll it out. Disabling the flag reverts back to the old behavior, where retries are throttled if there's still data remaining in the tree, but not if all the data has finished loading.

The new behavior is still enabled in the public builds.

This puts the change introduced by facebook#26611 behind a flag until Meta is
able to roll it out. Disabling the flag reverts back to the old
behavior, where retries are throttled if there's still data remaining
in the tree, but not if all the data has finished loading.

The new behavior is still enabled in the public builds.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 20, 2023
@react-sizebot
Copy link

Comparing: 7f8c501...65be78a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.67 kB 164.67 kB = 51.81 kB 51.81 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 168.43 kB 168.43 kB = 52.93 kB 52.93 kB
facebook-www/ReactDOM-prod.classic.js = 568.32 kB 568.33 kB +0.04% 100.61 kB 100.65 kB
facebook-www/ReactDOM-prod.modern.js = 552.05 kB 552.06 kB +0.04% 97.91 kB 97.95 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 65be78a

@acdlite acdlite merged commit d73d7d5 into facebook:main Apr 20, 2023
kassens pushed a commit that referenced this pull request Apr 21, 2023
This puts the change introduced by #26611 behind a flag until Meta is
able to roll it out. Disabling the flag reverts back to the old
behavior, where retries are throttled if there's still data remaining in
the tree, but not if all the data has finished loading.

The new behavior is still enabled in the public builds.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
This puts the change introduced by facebook#26611 behind a flag until Meta is
able to roll it out. Disabling the flag reverts back to the old
behavior, where retries are throttled if there's still data remaining in
the tree, but not if all the data has finished loading.

The new behavior is still enabled in the public builds.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
This puts the change introduced by #26611 behind a flag until Meta is
able to roll it out. Disabling the flag reverts back to the old
behavior, where retries are throttled if there's still data remaining in
the tree, but not if all the data has finished loading.

The new behavior is still enabled in the public builds.

DiffTrain build for commit d73d7d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants