Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameters from react-reconciler files #26576

Conversation

evrenkaraarslan
Copy link
Contributor

@evrenkaraarslan evrenkaraarslan commented Apr 8, 2023

Summary

Remove unused parameters in 5 files from react-reconciler

Changed files are
-packages/react-reconciler/src/ReactChildFiber.js
-packages/react-reconciler/src/ReactFiberBeginWork.js
-packages/react-reconciler/src/ReactFiberClassUpdateQueue.js
-packages/react-reconciler/src/ReactFiberCommitWork.js
-packages/react-reconciler/src/ReactFiberCompleteWork.js

How did you test this change?

I tested them with existing tests

@react-sizebot
Copy link

react-sizebot commented Apr 8, 2023

Comparing: 7b0642b...d0116f8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.35 kB 164.33 kB = 51.65 kB 51.64 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 166.79 kB 166.77 kB = 52.31 kB 52.30 kB
facebook-www/ReactDOM-prod.classic.js = 564.28 kB 564.18 kB = 99.34 kB 99.33 kB
facebook-www/ReactDOM-prod.modern.js = 548.07 kB 547.97 kB = 96.64 kB 96.63 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d0116f8

@sophiebits
Copy link
Collaborator

I'll let @acdlite confirm there's no reason to keep these, but this looks good to me.

@sophiebits sophiebits requested a review from acdlite April 11, 2023 19:53
@evrenkaraarslan
Copy link
Contributor Author

Hi, I noticed that this PR hasn't been merged yet. Should I close it? 👀 @sophiebits

@sophiebits
Copy link
Collaborator

Feel free to leave it open until someone has a chance to review.

Copy link

github-actions bot commented Apr 9, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 9, 2024
Copy link

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions bot closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants