-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused parameters from react-reconciler files #26576
Remove unused parameters from react-reconciler files #26576
Conversation
Comparing: 7b0642b...d0116f8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
I'll let @acdlite confirm there's no reason to keep these, but this looks good to me. |
Hi, I noticed that this PR hasn't been merged yet. Should I close it? 👀 @sophiebits |
Feel free to leave it open until someone has a chance to review. |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
Remove unused parameters in 5 files from react-reconciler
Changed files are
-packages/react-reconciler/src/ReactChildFiber.js
-packages/react-reconciler/src/ReactFiberBeginWork.js
-packages/react-reconciler/src/ReactFiberClassUpdateQueue.js
-packages/react-reconciler/src/ReactFiberCommitWork.js
-packages/react-reconciler/src/ReactFiberCompleteWork.js
How did you test this change?
I tested them with existing tests