Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: delete AppVeyor config #25373

Merged
merged 1 commit into from
Sep 30, 2022
Merged

CI: delete AppVeyor config #25373

merged 1 commit into from
Sep 30, 2022

Conversation

kassens
Copy link
Member

@kassens kassens commented Sep 30, 2022

I noticed this file as #24892 is updating the NodeJS version in it.

I don't think this is used for anything as the config just runs a handful of yarn commands and I assume that's all covered by CircleCI.

@kassens kassens requested review from bvaughn and acdlite September 30, 2022 22:02
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 30, 2022
I noticed this file as facebook#24892 is updating the NodeJS version in it.

I don't think this is used for anything as the config just runs a handful
of yarn commands and I assume that's all covered by CircleCI.
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't really know what this file is being used for. Delete it and just revert if something breaks? 🥳

@kassens kassens merged commit d061e6e into facebook:main Sep 30, 2022
@kassens kassens deleted the appveyor branch September 30, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants