Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land forked reconciler changes #24817

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Land forked reconciler changes #24817

merged 1 commit into from
Jun 30, 2022

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jun 30, 2022 •
edited
Loading

This applies forked changes from the "new" reconciler to the "old" one.

At Meta, these have been rolled out to 80% public for the past week.

I also ran the internal test suite to confirm nothing breaks.

Includes:

  • d410f0a [FORKED] Bugfix: Offscreen instance is null during setState
  • 58bb117 [FORKED] Check for infinite update loops even if unmounted
  • 31882b5 [FORKED] Bugfix: Revealing a hidden update
  • 17691ac [FORKED] Don't update childLanes until after current render

@acdlite
Land forked reconciler changes
6245ddf 
This applies forked changes from the "new" reconciler to the "old" one.

Includes:

- d410f0a [FORKED] Bugfix: Offscreen instance is null during setState
- 58bb117 [FORKED] Check for infinite update loops even if unmounted
- 31882b5 [FORKED] Bugfix: Revealing a hidden update
- 17691ac [FORKED] Don't update childLanes until after current render
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 30, 2022
@sizebot
Copy link

sizebot commented Jun 30, 2022

Comparing: 2e1c884...6245ddf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.14% 131.57 kB 131.75 kB +0.27% 42.27 kB 42.39 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.13% 136.84 kB 137.02 kB +0.25% 43.87 kB 43.98 kB
facebook-www/ReactDOM-prod.classic.js +0.18% 455.65 kB 456.45 kB +0.28% 82.90 kB 83.13 kB
facebook-www/ReactDOM-prod.modern.js +0.18% 440.88 kB 441.69 kB +0.25% 80.65 kB 80.85 kB
facebook-www/ReactDOMForked-prod.classic.js = 456.43 kB 456.45 kB +0.01% 83.13 kB 83.14 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.65% 656.37 kB 660.67 kB +1.05% 143.11 kB 144.62 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.65% 656.40 kB 660.70 kB +1.05% 143.13 kB 144.64 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js +0.65% 687.73 kB 692.16 kB +1.04% 144.66 kB 146.16 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js +0.65% 687.75 kB 692.19 kB +1.04% 144.68 kB 146.18 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.63% 681.97 kB 686.27 kB +1.00% 148.34 kB 149.82 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.63% 683.46 kB 687.76 kB +1.02% 147.91 kB 149.41 kB
oss-stable/react-art/cjs/react-art.development.js +0.63% 683.48 kB 687.78 kB +1.02% 147.93 kB 149.44 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js +0.62% 714.63 kB 719.07 kB +1.00% 149.93 kB 151.43 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.61% 695.85 kB 700.09 kB +0.98% 149.87 kB 151.33 kB
oss-experimental/react-art/cjs/react-art.development.js +0.61% 710.74 kB 715.04 kB +0.98% 153.61 kB 155.12 kB
react-native/implementations/ReactFabric-dev.js +0.59% 776.34 kB 780.93 kB +0.92% 169.15 kB 170.71 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.59% 717.35 kB 721.56 kB +0.96% 153.79 kB 155.27 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.59% 717.35 kB 721.56 kB +0.96% 153.79 kB 155.27 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.57% 746.23 kB 750.51 kB +0.95% 158.91 kB 160.42 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.57% 746.25 kB 750.53 kB +0.95% 158.94 kB 160.45 kB
react-native/implementations/ReactFabric-dev.fb.js +0.57% 813.09 kB 817.74 kB +0.90% 175.69 kB 177.26 kB
oss-stable-semver/react-art/umd/react-art.development.js +0.56% 786.99 kB 791.43 kB +0.90% 166.09 kB 167.58 kB
oss-stable/react-art/umd/react-art.development.js +0.56% 787.01 kB 791.45 kB +0.90% 166.11 kB 167.60 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.55% 773.79 kB 778.07 kB +0.91% 164.68 kB 166.18 kB
oss-experimental/react-art/umd/react-art.development.js +0.54% 815.61 kB 820.05 kB +0.90% 171.79 kB 173.33 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.54% 786.28 kB 790.52 kB +0.87% 171.58 kB 173.07 kB
facebook-www/ReactART-dev.modern.js +0.54% 785.89 kB 790.10 kB +0.89% 167.24 kB 168.72 kB
facebook-www/ReactART-dev.classic.js +0.53% 796.11 kB 800.32 kB +0.89% 169.34 kB 170.85 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.51% 823.11 kB 827.32 kB +0.83% 178.20 kB 179.68 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js +0.42% 1,026.48 kB 1,030.78 kB +0.67% 230.09 kB 231.62 kB
oss-stable/react-dom/cjs/react-dom.development.js +0.42% 1,026.50 kB 1,030.80 kB +0.67% 230.11 kB 231.65 kB
oss-stable-semver/react-dom/umd/react-dom.development.js +0.41% 1,076.94 kB 1,081.38 kB +0.66% 232.60 kB 234.13 kB
oss-stable/react-dom/umd/react-dom.development.js +0.41% 1,076.97 kB 1,081.41 kB +0.66% 232.62 kB 234.15 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.41% 1,048.92 kB 1,053.22 kB +0.64% 235.45 kB 236.97 kB
oss-experimental/react-dom/cjs/react-dom.development.js +0.41% 1,056.00 kB 1,060.31 kB +0.65% 236.40 kB 237.92 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.40% 1,047.63 kB 1,051.85 kB +0.64% 234.95 kB 236.44 kB
oss-experimental/react-dom/umd/react-dom.development.js +0.40% 1,107.91 kB 1,112.35 kB +0.65% 238.98 kB 240.53 kB
facebook-www/ReactDOMTesting-dev.classic.js +0.39% 1,076.26 kB 1,080.47 kB +0.64% 240.72 kB 242.25 kB
facebook-www/ReactDOM-dev.modern.js +0.36% 1,154.87 kB 1,159.08 kB +0.59% 254.39 kB 255.89 kB
facebook-www/ReactDOM-dev.classic.js +0.36% 1,178.49 kB 1,182.69 kB +0.59% 258.85 kB 260.39 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.32% 265.79 kB 266.63 kB +0.39% 48.13 kB 48.32 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.30% 281.40 kB 282.25 kB +0.36% 50.44 kB 50.62 kB
react-native/implementations/ReactFabric-prod.fb.js +0.29% 302.83 kB 303.71 kB +0.35% 54.70 kB 54.89 kB
react-native/implementations/ReactFabric-prod.js +0.29% 294.71 kB 295.56 kB +0.36% 53.08 kB 53.27 kB
facebook-www/ReactART-prod.modern.js +0.28% 283.33 kB 284.12 kB +0.35% 50.14 kB 50.31 kB
react-native/implementations/ReactFabric-profiling.js +0.27% 313.90 kB 314.75 kB +0.31% 56.32 kB 56.50 kB
facebook-www/ReactART-prod.classic.js +0.27% 294.17 kB 294.96 kB +0.36% 51.93 kB 52.12 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.27% 329.95 kB 330.83 kB +0.30% 58.98 kB 59.16 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.26% 302.02 kB 302.79 kB +0.29% 54.19 kB 54.35 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.24% 310.18 kB 310.93 kB +0.31% 55.79 kB 55.96 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.24% 321.14 kB 321.91 kB +0.29% 57.38 kB 57.54 kB
oss-stable-semver/react-art/cjs/react-art.production.min.js +0.22% 81.74 kB 81.92 kB +0.44% 25.44 kB 25.56 kB
oss-stable/react-art/cjs/react-art.production.min.js +0.22% 81.77 kB 81.95 kB +0.46% 25.44 kB 25.56 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.22% 337.24 kB 337.98 kB +0.28% 60.11 kB 60.28 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js +0.21% 89.00 kB 89.18 kB +0.41% 27.53 kB 27.64 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js +0.21% 89.02 kB 89.20 kB +0.40% 27.53 kB 27.64 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js +0.21% 89.28 kB 89.47 kB +0.54% 27.92 kB 28.07 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js +0.21% 89.31 kB 89.49 kB +0.54% 27.92 kB 28.07 kB
oss-experimental/react-art/cjs/react-art.production.min.js +0.20% 86.54 kB 86.72 kB +0.58% 26.86 kB 27.02 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js +0.20% 93.73 kB 93.92 kB +0.48% 29.23 kB 29.37 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.20% 422.42 kB 423.27 kB +0.25% 79.19 kB 79.39 kB

Generated by 🚫 dangerJS against 6245ddf

@acdlite acdlite merged commit 6b6cf83 into facebook:main Jun 30, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Sep 6, 2022
@sammy-SC @facebook-github-bot
React Native sync for revisions 229c86a...c1f5884
37d0a25 
Summary:
This sync includes the following changes:
- **[c1f5884ff](facebook/react@c1f5884ff )**: Add missing null checks to OffscreenInstance code ([#24846](facebook/react#24846)) //<Andrew Clark>//
- **[4cd788aef](facebook/react@4cd788aef )**: Revert "Revert [Transition Tracing] Refactor Transition Tracing Root Code" ([#24830](facebook/react#24830)) //<Luna Ruan>//
- **[e61fd91f5](facebook/react@e61fd91f5 )**: Revert "[Transition Tracing] Refactor Transition Tracing Root Code ([#24766](facebook/react#24766))" ([#24829](facebook/react#24829)) //<Andrew Clark>//
- **[401296310](facebook/react@401296310 )**: [Transition Tracing] Refactor Transition Tracing Root Code ([#24766](facebook/react#24766)) //<Luna Ruan>//
- **[185932902](facebook/react@185932902 )**: Track nearest Suspense handler on stack ([#24585](facebook/react#24585)) //<Andrew Clark>//
- **[a7b192e0f](facebook/react@a7b192e0f )**: Add test gate alias for Offscreen ([#24749](facebook/react#24749)) //<Andrew Clark>//
- **[6b6cf8311](facebook/react@6b6cf8311 )**: Land forked reconciler changes ([#24817](facebook/react#24817)) //<Andrew Clark>//
- **[d1432ba93](facebook/react@d1432ba93 )**: [Transition Tracing] Fix excess calls to the transition start callback ([#24806](facebook/react#24806)) //<Luna Ruan>//
- **[88574c1b8](facebook/react@88574c1b8 )**: Fix enableTransitionTracing flag ([#24801](facebook/react#24801)) //<Luna Ruan>//
- **[a4bed4696](facebook/react@a4bed4696 )**: [Transition Tracing] Add Tracing Markers ([#24686](facebook/react#24686)) //<Luna Ruan>//
- **[167853026](facebook/react@167853026 )**: fix hydration warning suppression in text comparisons ([#24784](facebook/react#24784)) //<Josh Story>//
- **[9abe745aa](facebook/react@9abe745aa )**: [DevTools][Timeline Profiler] Component Stacks Backend ([#24776](facebook/react#24776)) //<Luna Ruan>//
- **[cf665c4b7](facebook/react@cf665c4b7 )**: [DevTools] Refactor incompleteTransitions field from Root Fiber memoized state to FiberRoot ([#24765](facebook/react#24765)) //<Luna Ruan>//
- **[56389e81f](facebook/react@56389e81f )**: Abort Flight ([#24754](facebook/react#24754)) //<Sebastian Markbåge>//
- **[0f216ae31](facebook/react@0f216ae31 )**: Add entry points for "static" server rendering passes ([#24752](facebook/react#24752)) //<Sebastian Markbåge>//
- **[f796fa13a](facebook/react@f796fa13a )**: Rename Segment to Task in Flight ([#24753](facebook/react#24753)) //<Sebastian Markbåge>//
- **[0f0aca3ab](facebook/react@0f0aca3ab )**: Aborting early should not infinitely suspend ([#24751](facebook/react#24751)) //<Sebastian Markbåge>//
- **[12a738f1a](facebook/react@12a738f1a )**: [Transition Tracing] Add Support for Multiple Transitions on Root ([#24732](facebook/react#24732)) //<Luna Ruan>//
- **[72ebc703a](facebook/react@72ebc703a )**: [DevTools] fix useDeferredValue to match reconciler change ([#24742](facebook/react#24742)) //<Mengdi Chen>//
- **[7cf9f5e03](facebook/react@7cf9f5e03 )**: Extra space ([#24612](facebook/react#24612)) //<Kerim Büyükakyüz>//

Changelog:
[General][Changed] - React Native sync for revisions 229c86a...c1f5884

Reviewed By: mdvacca, GijsWeterings

Differential Revision: D38904311

fbshipit-source-id: 1e30bc420c30ec7a0c0073fc92a706afef4b3340
cipolleschi pushed a commit to facebook/react-native that referenced this pull request Sep 7, 2022
@sammy-SC
React Native sync for revisions 229c86a...c1f5884
d9cd5a5 
Summary:
This sync includes the following changes:
- **[c1f5884ff](facebook/react@c1f5884ff )**: Add missing null checks to OffscreenInstance code ([#24846](facebook/react#24846)) //<Andrew Clark>//
- **[4cd788aef](facebook/react@4cd788aef )**: Revert "Revert [Transition Tracing] Refactor Transition Tracing Root Code" ([#24830](facebook/react#24830)) //<Luna Ruan>//
- **[e61fd91f5](facebook/react@e61fd91f5 )**: Revert "[Transition Tracing] Refactor Transition Tracing Root Code ([#24766](facebook/react#24766))" ([#24829](facebook/react#24829)) //<Andrew Clark>//
- **[401296310](facebook/react@401296310 )**: [Transition Tracing] Refactor Transition Tracing Root Code ([#24766](facebook/react#24766)) //<Luna Ruan>//
- **[185932902](facebook/react@185932902 )**: Track nearest Suspense handler on stack ([#24585](facebook/react#24585)) //<Andrew Clark>//
- **[a7b192e0f](facebook/react@a7b192e0f )**: Add test gate alias for Offscreen ([#24749](facebook/react#24749)) //<Andrew Clark>//
- **[6b6cf8311](facebook/react@6b6cf8311 )**: Land forked reconciler changes ([#24817](facebook/react#24817)) //<Andrew Clark>//
- **[d1432ba93](facebook/react@d1432ba93 )**: [Transition Tracing] Fix excess calls to the transition start callback ([#24806](facebook/react#24806)) //<Luna Ruan>//
- **[88574c1b8](facebook/react@88574c1b8 )**: Fix enableTransitionTracing flag ([#24801](facebook/react#24801)) //<Luna Ruan>//
- **[a4bed4696](facebook/react@a4bed4696 )**: [Transition Tracing] Add Tracing Markers ([#24686](facebook/react#24686)) //<Luna Ruan>//
- **[167853026](facebook/react@167853026 )**: fix hydration warning suppression in text comparisons ([#24784](facebook/react#24784)) //<Josh Story>//
- **[9abe745aa](facebook/react@9abe745aa )**: [DevTools][Timeline Profiler] Component Stacks Backend ([#24776](facebook/react#24776)) //<Luna Ruan>//
- **[cf665c4b7](facebook/react@cf665c4b7 )**: [DevTools] Refactor incompleteTransitions field from Root Fiber memoized state to FiberRoot ([#24765](facebook/react#24765)) //<Luna Ruan>//
- **[56389e81f](facebook/react@56389e81f )**: Abort Flight ([#24754](facebook/react#24754)) //<Sebastian Markbåge>//
- **[0f216ae31](facebook/react@0f216ae31 )**: Add entry points for "static" server rendering passes ([#24752](facebook/react#24752)) //<Sebastian Markbåge>//
- **[f796fa13a](facebook/react@f796fa13a )**: Rename Segment to Task in Flight ([#24753](facebook/react#24753)) //<Sebastian Markbåge>//
- **[0f0aca3ab](facebook/react@0f0aca3ab )**: Aborting early should not infinitely suspend ([#24751](facebook/react#24751)) //<Sebastian Markbåge>//
- **[12a738f1a](facebook/react@12a738f1a )**: [Transition Tracing] Add Support for Multiple Transitions on Root ([#24732](facebook/react#24732)) //<Luna Ruan>//
- **[72ebc703a](facebook/react@72ebc703a )**: [DevTools] fix useDeferredValue to match reconciler change ([#24742](facebook/react#24742)) //<Mengdi Chen>//
- **[7cf9f5e03](facebook/react@7cf9f5e03 )**: Extra space ([#24612](facebook/react#24612)) //<Kerim Büyükakyüz>//

Changelog:
[General][Changed] - React Native sync for revisions 229c86a...c1f5884

Reviewed By: mdvacca, GijsWeterings

Differential Revision: D38904311

fbshipit-source-id: 1e30bc420c30ec7a0c0073fc92a706afef4b3340
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@sammy-SC @OlimpiaZurek
React Native sync for revisions 229c86a...c1f5884
d835434 
Summary:
This sync includes the following changes:
- **[c1f5884ff](facebook/react@c1f5884ff )**: Add missing null checks to OffscreenInstance code ([facebook#24846](facebook/react#24846)) //<Andrew Clark>//
- **[4cd788aef](facebook/react@4cd788aef )**: Revert "Revert [Transition Tracing] Refactor Transition Tracing Root Code" ([facebook#24830](facebook/react#24830)) //<Luna Ruan>//
- **[e61fd91f5](facebook/react@e61fd91f5 )**: Revert "[Transition Tracing] Refactor Transition Tracing Root Code ([facebook#24766](facebook/react#24766))" ([facebook#24829](facebook/react#24829)) //<Andrew Clark>//
- **[401296310](facebook/react@401296310 )**: [Transition Tracing] Refactor Transition Tracing Root Code ([facebook#24766](facebook/react#24766)) //<Luna Ruan>//
- **[185932902](facebook/react@185932902 )**: Track nearest Suspense handler on stack ([facebook#24585](facebook/react#24585)) //<Andrew Clark>//
- **[a7b192e0f](facebook/react@a7b192e0f )**: Add test gate alias for Offscreen ([facebook#24749](facebook/react#24749)) //<Andrew Clark>//
- **[6b6cf8311](facebook/react@6b6cf8311 )**: Land forked reconciler changes ([facebook#24817](facebook/react#24817)) //<Andrew Clark>//
- **[d1432ba93](facebook/react@d1432ba93 )**: [Transition Tracing] Fix excess calls to the transition start callback ([facebook#24806](facebook/react#24806)) //<Luna Ruan>//
- **[88574c1b8](facebook/react@88574c1b8 )**: Fix enableTransitionTracing flag ([facebook#24801](facebook/react#24801)) //<Luna Ruan>//
- **[a4bed4696](facebook/react@a4bed4696 )**: [Transition Tracing] Add Tracing Markers ([facebook#24686](facebook/react#24686)) //<Luna Ruan>//
- **[167853026](facebook/react@167853026 )**: fix hydration warning suppression in text comparisons ([facebook#24784](facebook/react#24784)) //<Josh Story>//
- **[9abe745aa](facebook/react@9abe745aa )**: [DevTools][Timeline Profiler] Component Stacks Backend ([facebook#24776](facebook/react#24776)) //<Luna Ruan>//
- **[cf665c4b7](facebook/react@cf665c4b7 )**: [DevTools] Refactor incompleteTransitions field from Root Fiber memoized state to FiberRoot ([facebook#24765](facebook/react#24765)) //<Luna Ruan>//
- **[56389e81f](facebook/react@56389e81f )**: Abort Flight ([facebook#24754](facebook/react#24754)) //<Sebastian Markbåge>//
- **[0f216ae31](facebook/react@0f216ae31 )**: Add entry points for "static" server rendering passes ([facebook#24752](facebook/react#24752)) //<Sebastian Markbåge>//
- **[f796fa13a](facebook/react@f796fa13a )**: Rename Segment to Task in Flight ([facebook#24753](facebook/react#24753)) //<Sebastian Markbåge>//
- **[0f0aca3ab](facebook/react@0f0aca3ab )**: Aborting early should not infinitely suspend ([facebook#24751](facebook/react#24751)) //<Sebastian Markbåge>//
- **[12a738f1a](facebook/react@12a738f1a )**: [Transition Tracing] Add Support for Multiple Transitions on Root ([facebook#24732](facebook/react#24732)) //<Luna Ruan>//
- **[72ebc703a](facebook/react@72ebc703a )**: [DevTools] fix useDeferredValue to match reconciler change ([facebook#24742](facebook/react#24742)) //<Mengdi Chen>//
- **[7cf9f5e03](facebook/react@7cf9f5e03 )**: Extra space ([facebook#24612](facebook/react#24612)) //<Kerim Büyükakyüz>//

Changelog:
[General][Changed] - React Native sync for revisions 229c86a...c1f5884

Reviewed By: mdvacca, GijsWeterings

Differential Revision: D38904311

fbshipit-source-id: 1e30bc420c30ec7a0c0073fc92a706afef4b3340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunaruan lunaruan lunaruan approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sizebot @lunaruan @facebook-github-bot