Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTool] fix build-for-devtools script #24764

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

mondaychen
Copy link
Contributor

Summary

Add back react-dom/test-utils to yarn build-for-devtools as it's still used by tests such as yarn test --build --project=devtools -r=experimental

How did you test this change?

yarn build-for-devtools
yarn test --build --project=devtools -r=experimental

@sizebot
Copy link

sizebot commented Jun 20, 2022

Comparing: 56389e8...625d157

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.64 kB 131.64 kB = 42.30 kB 42.30 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.92 kB 136.92 kB = 43.89 kB 43.89 kB
facebook-www/ReactDOM-prod.classic.js = 440.83 kB 440.83 kB = 80.64 kB 80.64 kB
facebook-www/ReactDOM-prod.modern.js = 426.13 kB 426.13 kB = 78.45 kB 78.45 kB
facebook-www/ReactDOMForked-prod.classic.js = 441.61 kB 441.61 kB = 80.87 kB 80.87 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 625d157

@mondaychen mondaychen merged commit d6255f0 into facebook:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants