Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce repetition between Timeline in-memory profiler and Chrome Event Trace parser #23208

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 28, 2022

Reduce repetition between Timeline in-memory profiler and Chrome Event Trace parser.

Broken into separate commits:

  • Moved the in-memory stack management out of 'profilingHooks.js' and into the new 'TimelineData.js'.
  • Update 'preprocessData.js' to also use the new 'TimelineData.js' when parsing Trace Event data.

Builds on top of #23185.

Related to #22529.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 28, 2022
@bvaughn bvaughn force-pushed the devtools-profiler-refactor-phase-7 branch 2 times, most recently from bcf4e79 to a6121a0 Compare January 28, 2022 21:55
Moved the in-memory stack management out of 'profilingHooks.js' and into the new 'TimelineData.js'. Doing this even caught a small time offset bug (fixed).

Next step will be to update 'preprocessData.js' to also use the new 'TimelineData.js' when parsing Trace Event data.
@bvaughn bvaughn force-pushed the devtools-profiler-refactor-phase-7 branch from a6121a0 to d6e3bf3 Compare January 28, 2022 22:24
@facebook-github-bot
Copy link

Hi @bvaughn!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Component: Developer Tools React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants