DevTools logs Timeline metadata only once (when profiling starts) #23141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
changed the title
|
Comparing: 505c15c...3d8192b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
force-pushed
the
devtools-profiler-refactor-phase-3
branch
from
5c5f367
to
c43999d
Compare
added 4 commits
January 20, 2022 13:51
React will call the DevTools profiling hooks unconditionally (for DEV and profiling builds) but DevTools will only log the data to the User Timing API when DevTools is profiling.
bvaughn
force-pushed
the
devtools-profiler-refactor-phase-3
branch
from
c43999d
to
f10cfea
Compare
bvaughn
force-pushed
the
devtools-profiler-refactor-phase-3
branch
from
f10cfea
to
3d8192b
Compare
lunaruan
approved these changes
Jan 20, 2022
|
Squashed into #23158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #23137.
Only adds one commit, which addresses a previous TODO comment in
profilingHooks.js:Related to #22529.
Note that this PR (in isolation) makes the Timeline profiler feature unusable. It will be part of a stack of PRs that will be merged together once finished.