Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment support to @gate pragma #21881

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jul 14, 2021

So you can more easily comment on why a test is gated.

So you can more easily comment on why a test is gated.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 14, 2021
@sizebot
Copy link

sizebot commented Jul 14, 2021

Comparing: 8134676...1d966ba

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.74 kB 126.74 kB = 40.61 kB 40.61 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.56 kB 129.56 kB = 41.56 kB 41.56 kB
facebook-www/ReactDOM-prod.classic.js = 402.95 kB 402.95 kB = 74.61 kB 74.61 kB
facebook-www/ReactDOM-prod.modern.js = 391.65 kB 391.65 kB = 72.89 kB 72.89 kB
facebook-www/ReactDOMForked-prod.classic.js = 402.95 kB 402.95 kB = 74.61 kB 74.61 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1d966ba

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@acdlite acdlite merged commit f0efb7b into facebook:main Jul 14, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
So you can more easily comment on why a test is gated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants