Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI on master #21365

Closed
wants to merge 4 commits into from
Closed

fix CI on master #21365

wants to merge 4 commits into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 27, 2021

Summary

Naive fix after #21357 broke CI on master.

Note that CI cannot be green since the base commit is broken.

Test Plan

  • CI green

eps1lon added 3 commits April 27, 2021 12:31
This reverts commit e1cb0e9 and a254482.

Too high of a risk to hide real problems. Manual review should be enough.
@sebmarkbage
Copy link
Collaborator

I just pushed directly to master. 9a25916

@eps1lon eps1lon deleted the chore/fix-master branch June 30, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants