-
Notifications
You must be signed in to change notification settings - Fork 47.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8 does not have a setter for property "enctype" #2135
Conversation
Switched it to use |
cc @yungsters |
Thanks for fixing this. In addition to having to set |
@yungsters IE8 throws, but I figure it's not worth special-casing as you really really should use valid mimetypes (and everyone uses one of the two common, with one of them being default too). |
Perhaps we should introduce an |
Maybe. Can you add the following test case to your Test Plan (ine IE8):
|
It works because of |
@yungsters Pinging here as well :) As for IE8 throwing when setting invalid values, it is a widespread issue with IE8 and I would say outside the scope of this PR. |
Looks good to me. |
IE8 does not have a setter for property "enctype"
Outputs (on IE8):
Whereas with
f.encoding = 'multipart/form-data';
orf.setAttribute('enctype', 'multipart/form-data');
:Unlikely that anyone would ever bump into this, but it is super-weird if you would and it's pretty much for free so why not.