Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fast Refresh] Support callthrough HOCs #21104

Merged
merged 8 commits into from
Mar 30, 2021
Merged

[Fast Refresh] Support callthrough HOCs #21104

merged 8 commits into from
Mar 30, 2021

Commits on Mar 26, 2021

  1. [Fast Refresh] Support callthrough HOCs

    @gaearon
    gaearon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    3b72b8f View commit details
    Browse the repository at this point in the history

  2. Add a newly failing testing to demonstrate the flaw 

    This shows why my initial approach doesn't make sense.
    @gaearon
    gaearon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    38423eb View commit details
    Browse the repository at this point in the history

  3. Attach signatures at every nesting level

    @gaearon
    gaearon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    a804fbc View commit details
    Browse the repository at this point in the history

  4. Sign nested memo/forwardRef too

    @gaearon
    gaearon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    77a9ef3 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Add an IIFE test 

    This is not a case that is important for Fast Refresh, but we shouldn't change the code semantics. This case shows the transform isn't quite correct. It's wrapping the call at the wrong place.
    @gaearon
    gaearon committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d2a2045 View commit details
    Browse the repository at this point in the history

  2. Find HOCs above more precisely 

    This fixes a false positive that was causing an IIFE to be wrapped in the wrong place, which made the wrapping unsafe.
    @gaearon
    gaearon committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    070262b View commit details
    Browse the repository at this point in the history

  3. Be defensive against non-components being passed to setSignature

    @gaearon
    gaearon committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8ffb8cd View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @gaearon
    gaearon committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    00178db View commit details
    Browse the repository at this point in the history