Use EventPriority to track update priority #21082

acdlite · 2021-03-24T23:50:40Z

Instead of LanePriority. Internally, EventPriority is just a lane, so this skips an extra conversion. Since EventPriority is a "public" (to the host config) type, I was also able to remove some deep imports of the Lane module.

This gets us most of the way to deleting the LanePriority entirely.

acdlite · 2021-03-24T23:54:04Z

packages/react-reconciler/src/ReactEventPriorities.new.js

+
+let currentUpdatePriority: EventPriority = NoLane;
+
+export function getCurrentUpdatePriority(): EventPriority {


Re: naming, I was thinking I would rename this to getCurrentEventPriority, and then rename the host config one to something like getCurrentHostEventPriority. Gonna leave as-is in this PR, though.

Why bother to rename more than this if we're going to remove it?

This is staying. It tracks a Lane now instead of a LanePriority.

sizebot · 2021-03-24T23:54:55Z

Comparing: 148f8e4...4b7ff7f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	122.62 kB	122.51 kB	=	39.45 kB	39.45 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	129.02 kB	128.94 kB	+0.11%	41.43 kB	41.48 kB
facebook-www/ReactDOM-prod.classic.js	=	407.89 kB	406.90 kB	=	75.53 kB	75.49 kB
facebook-www/ReactDOM-prod.modern.js	=	396.14 kB	395.16 kB	=	73.62 kB	73.57 kB
facebook-www/ReactDOMForked-prod.classic.js	=	407.89 kB	406.90 kB	=	75.53 kB	75.49 kB
oss-experimental/react-reconciler/cjs/react-reconciler-constants.development.js	+11.67%	1.71 kB	1.90 kB	+2.35%	0.81 kB	0.83 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.development.js	+11.67%	1.71 kB	1.90 kB	+2.35%	0.81 kB	0.83 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/react-reconciler/cjs/react-reconciler-constants.development.js	+11.67%	1.71 kB	1.90 kB	+2.35%	0.81 kB	0.83 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.development.js	+11.67%	1.71 kB	1.90 kB	+2.35%	0.81 kB	0.83 kB
facebook-www/ReactDOMTesting-prod.classic.js	=	399.78 kB	398.95 kB	=	75.50 kB	75.45 kB
facebook-www/ReactDOMTesting-prod.modern.js	=	385.99 kB	385.16 kB	=	73.20 kB	73.16 kB
react-native/implementations/ReactFabric-profiling.js	=	285.51 kB	284.89 kB	=	51.06 kB	50.97 kB
react-native/implementations/ReactFabric-profiling.fb.js	=	285.46 kB	284.84 kB	=	51.03 kB	50.95 kB
facebook-www/ReactDOM-prod.classic.js	=	407.89 kB	406.90 kB	=	75.53 kB	75.49 kB
facebook-www/ReactDOMForked-prod.classic.js	=	407.89 kB	406.90 kB	=	75.53 kB	75.49 kB
facebook-www/ReactDOM-prod.modern.js	=	396.14 kB	395.16 kB	=	73.62 kB	73.57 kB
facebook-www/ReactDOMForked-prod.modern.js	=	396.15 kB	395.16 kB	=	73.63 kB	73.58 kB
react-native/implementations/ReactNativeRenderer-profiling.js	=	292.84 kB	292.10 kB	+0.03%	52.43 kB	52.44 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js	=	292.78 kB	292.03 kB	+0.03%	52.40 kB	52.41 kB
react-native/implementations/ReactFabric-prod.js	=	272.86 kB	272.16 kB	=	48.70 kB	48.62 kB
react-native/implementations/ReactFabric-prod.fb.js	=	272.81 kB	272.11 kB	=	48.68 kB	48.59 kB
react-native/implementations/ReactNativeRenderer-prod.js	=	280.21 kB	279.39 kB	=	50.06 kB	50.04 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js	=	280.16 kB	279.33 kB	=	50.03 kB	50.01 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js	=	252.70 kB	251.93 kB	+0.02%	46.23 kB	46.24 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js	=	240.19 kB	239.34 kB	=	43.95 kB	43.92 kB
facebook-www/ReactART-prod.classic.js	=	263.43 kB	262.46 kB	=	46.69 kB	46.63 kB
facebook-www/ReactART-prod.modern.js	=	256.07 kB	255.09 kB	=	45.45 kB	45.41 kB

Generated by 🚫 dangerJS against 4b7ff7f

Instead of LanePriority. Internally, EventPriority is just a lane, so this skips an extra conversion. Since EventPriority is a "public" (to the host config) type, I was also able to remove some deep imports of the Lane module. This gets us most of the way to deleting the LanePriority entirely.

rickhanlonii · 2021-03-25T14:18:30Z

packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js

-// Copied from ReactFiberLanes. Don't do this!
-// This is hard coded directly to avoid needing to import, and
-// we'll remove this as we replace runWithPriority with React APIs.
-export const IdleLanePriority = 2;


rickhanlonii · 2021-03-25T14:20:03Z

packages/react-dom/src/events/ReactDOMEventReplaying.js

    const queuedTarget: QueuedHydrationTarget = {
      blockedOn: null,
      target: target,
-      lanePriority: updateLanePriority,
+      priority: updatePriority,


It comes full circle - this was the original name of the field when it was the scheduler priority, which we had to keep alongside lanePriority.

rickhanlonii · 2021-03-25T14:20:33Z

packages/react-dom/src/events/ReactDOMEventReplaying.js

    };
    let i = 0;
    for (; i < queuedExplicitHydrationTargets.length; i++) {
+      // Stop once we hit the first target with lower priority than


Lower than what?

rickhanlonii · 2021-03-25T14:21:01Z

packages/react-dom/src/events/ReactDOMEventReplaying.js

+        !isHigherEventPriority(
+          updatePriority,
+          queuedExplicitHydrationTargets[i].priority,
+        )


rickhanlonii · 2021-03-25T14:23:13Z

packages/react-reconciler/src/ReactEventPriorities.js

+  ? (IdleEventPriority_new: any)
+  : (IdleEventPriority_old: any);
+
+export function runWithPriority<T>(priority: EventPriority, fn: () => T): T {


I think this is only for tests now - how long until we can remove this? We'll need Offscreen for the low priority, but can we replace the Continuous with something that's actually continuous instead?

rickhanlonii · 2021-03-25T14:23:46Z

packages/react-reconciler/src/ReactEventPriorities.new.js

+
+let currentUpdatePriority: EventPriority = NoLane;
+
+export function getCurrentUpdatePriority(): EventPriority {


Why bother to rename more than this if we're going to remove it?

rickhanlonii · 2021-03-25T14:24:30Z

packages/react-reconciler/src/ReactFiberCommitWork.new.js

@@ -1067,7 +1067,6 @@ function commitUnmount(
  finishedRoot: FiberRoot,
  current: Fiber,
  nearestMountedAncestor: Fiber,
-  renderPriorityLevel: LanePriority,


Nice find, I noticed this was unused too.

rickhanlonii · 2021-03-25T14:27:51Z

packages/react-reconciler/src/ReactFiberDevToolsHook.old.js

-        const schedulerPriority =
-          priorityLevel === NoLanePriority
-            ? NormalPriority
-            : lanePriorityToSchedulerPriority(priorityLevel);


Why inline? Do you anticipate this is the only place you'll need to do this conversion?

Currently it is, yeah. Also there's a backlog item to discuss what kind of priority to expose and how. Scheduler priority doesn't really make sense anymore because of our decoupling work.

So inlining makes it harder for it to leak to more places.

rickhanlonii · 2021-03-25T14:28:50Z

packages/react-reconciler/src/ReactEventPriorities.js

+
+export const DiscreteEventPriority: EventPriority = enableNewReconciler
+  ? (DiscreteEventPriority_new: any)
+  : (DiscreteEventPriority_old: any);


Why any type them?

The host config isn't forked, but it handles types from both reconciler forks. Like Fiber is technically a cross-fork type, because it gets passed between the host config and reconciler. That's why we have the ReactInternalTypes module.

Other than forking all the renderers, there's no way (at least that I've that I've found) to express that the type passed is the correct one for the given fork. So we cheat.

Summary: This sync includes the following changes: - **[c9aab1c9d](facebook/react@c9aab1c9d )**: [email protected] //<Dan Abramov>// - **[516b76b9a](facebook/react@516b76b9a )**: [Fast Refresh] Support callthrough HOCs ([#21104](facebook/react#21104)) //<Dan Abramov>// - **[0853aab74](facebook/react@0853aab74 )**: Log all errors to console.error by default ([#21130](facebook/react#21130)) //<Sebastian Markbåge>// - **[d1294c9d4](facebook/react@d1294c9d4 )**: Add global onError handler ([#21129](facebook/react#21129)) //<Sebastian Markbåge>// - **[64983aab5](facebook/react@64983aab5 )**: Remove redundant setUpdatePriority call ([#21127](facebook/react#21127)) //<Andrew Clark>// - **[634cc52e6](facebook/react@634cc52e6 )**: Delete dead variable: currentEventWipLanes ([#21123](facebook/react#21123)) //<Andrew Clark>// - **[1102224bb](facebook/react@1102224bb )**: Fix: flushSync changes priority inside effect ([#21122](facebook/react#21122)) //<Andrew Clark>// - **[dbe98a5aa](facebook/react@dbe98a5aa )**: Move sync task queue to its own module ([#21109](facebook/react#21109)) //<Andrew Clark>// - **[3ba5c8737](facebook/react@3ba5c8737 )**: Remove Scheduler indirection ([#21107](facebook/react#21107)) //<Andrew Clark>// - **[46b68eaf6](facebook/react@46b68eaf6 )**: Delete LanePriority type ([#21090](facebook/react#21090)) //<Andrew Clark>// - **[dcd13045e](facebook/react@dcd13045e )**: Use Lane to track root callback priority ([#21089](facebook/react#21089)) //<Andrew Clark>// - **[5f21a9fca](facebook/react@5f21a9fca )**: Clean up host pointers in level 2 of clean-up flag ([#21112](facebook/react#21112)) //<Andrew Clark>// - **[32d6f39ed](facebook/react@32d6f39ed )**: [Fizz] Support special HTML/SVG/MathML tags to suspend ([#21113](facebook/react#21113)) //<Sebastian Markbåge>// - **[a77dd13ed](facebook/react@a77dd13ed )**: Delete enableDiscreteEventFlushingChange ([#21110](facebook/react#21110)) //<Andrew Clark>// - **[048ee4c0c](facebook/react@048ee4c0c )**: Use `act` in fuzz tester to flush expired work ([#21108](facebook/react#21108)) //<Andrew Clark>// - **[556644e23](facebook/react@556644e23 )**: Fix plurals ([#21106](facebook/react#21106)) //<Sebastian Markbåge>// - **[8b741437b](facebook/react@8b741437b )**: Rename SuspendedWork to Task ([#21105](facebook/react#21105)) //<Sebastian Markbåge>// - **[38a1aedb4](facebook/react@38a1aedb4 )**: [Fizz] Add FormatContext and Refactor Work ([#21103](facebook/react#21103)) //<Sebastian Markbåge>// - **[1b7e471b9](facebook/react@1b7e471b9 )**: React Native New Architecture: Support passing nativeViewTag to getInspectorDataForViewAtPoint callback, for React DevTools compat ([#21080](facebook/react#21080)) //<Joshua Gross>// - **[4a99c5c3a](facebook/react@4a99c5c3a )**: Use highest priority lane to detect interruptions ([#21088](facebook/react#21088)) //<Andrew Clark>// - **[77be52729](facebook/react@77be52729 )**: Remove LanePriority from computeExpirationTime ([#21087](facebook/react#21087)) //<Andrew Clark>// - **[3221e8fba](facebook/react@3221e8fba )**: Remove LanePriority from getBumpedLaneForHydration ([#21086](facebook/react#21086)) //<Andrew Clark>// - **[05ec0d764](facebook/react@05ec0d764 )**: Entangled expired lanes with SyncLane ([#21083](facebook/react#21083)) //<Andrew Clark>// - **[03ede83d2](facebook/react@03ede83d2 )**: Use EventPriority to track update priority ([#21082](facebook/react#21082)) //<Andrew Clark>// - **[a63f0953b](facebook/react@a63f0953b )**: Delete SyncBatchedLane ([#21061](facebook/react#21061)) //<Ricky>// - **[fa868d6be](facebook/react@fa868d6be )**: Make opaque EventPriority type a Lane internally ([#21065](facebook/react#21065)) //<Andrew Clark>// - **[eb58c3909](facebook/react@eb58c3909 )**: react-hooks/exhaustive-deps: Handle optional chained methods as dependency ([#20204](facebook/react#20204)) ([#20247](facebook/react#20247)) //<Ari Perkkiö>// - **[7b84dbd16](facebook/react@7b84dbd16 )**: Fail build on deep requires in npm packages ([#21063](facebook/react#21063)) //<Dan Abramov>// - **[2c9d8efc8](facebook/react@2c9d8efc8 )**: Add react-reconciler/constants entry point ([#21062](facebook/react#21062)) //<Dan Abramov>// - **[d0eaf7829](facebook/react@d0eaf7829 )**: Move priorities to separate import to break cycle ([#21060](facebook/react#21060)) //<Andrew Clark>// - **[435cff986](facebook/react@435cff986 )**: [Fizz] Expose callbacks in options for when various stages of the content is done ([#21056](facebook/react#21056)) //<Sebastian Markbåge>// - **[25bfa287f](facebook/react@25bfa287f )**: [Experiment] Add feature flag for more aggressive memory clean-up of deleted fiber trees ([#21039](facebook/react#21039)) //<Benoit Girard>// - **[8fe7810e7](facebook/react@8fe7810e7 )**: Remove already completed comment ([#21054](facebook/react#21054)) //<Sebastian Markbåge>// - **[6c3202b1e](facebook/react@6c3202b1e )**: [Fizz] Use identifierPrefix to avoid conflicts within the same response ([#21037](facebook/react#21037)) //<Sebastian Markbåge>// - **[dcdf8de7e](facebook/react@dcdf8de7e )**: Remove discrete lanes and priorities ([#21040](facebook/react#21040)) //<Andrew Clark>// - **[ca99ae97b](facebook/react@ca99ae97b )**: Replace some flushExpired callsites ([#20975](facebook/react#20975)) //<Ricky>// - **[1fafac002](facebook/react@1fafac002 )**: Use SyncLane for discrete event hydration ([#21038](facebook/react#21038)) //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions 6d3ecb7...c9aab1c jest_e2e[run_all_tests] Reviewed By: JoshuaGross Differential Revision: D27436763 fbshipit-source-id: da79a41e26bffdcdacd293178062edf098e9b58a

I screwed this up in facebook#21082. Got confused by the < versus > thing again. The helper functions are annoying, too, because I always forget the intended order of the arguments. But they're still helpful because when we refactor the type we only have the change the logic in one place. Added a regression test.

I screwed this up in #21082. Got confused by the < versus > thing again. The helper functions are annoying, too, because I always forget the intended order of the arguments. But they're still helpful because when we refactor the type we only have the change the logic in one place. Added a regression test.

Instead of LanePriority. Internally, EventPriority is just a lane, so this skips an extra conversion. Since EventPriority is a "public" (to the host config) type, I was also able to remove some deep imports of the Lane module. This gets us most of the way to deleting the LanePriority entirely.

I screwed this up in facebook#21082. Got confused by the < versus > thing again. The helper functions are annoying, too, because I always forget the intended order of the arguments. But they're still helpful because when we refactor the type we only have the change the logic in one place. Added a regression test.

Instead of LanePriority. Internally, EventPriority is just a lane, so this skips an extra conversion. Since EventPriority is a "public" (to the host config) type, I was also able to remove some deep imports of the Lane module. This gets us most of the way to deleting the LanePriority entirely.

I screwed this up in facebook#21082. Got confused by the < versus > thing again. The helper functions are annoying, too, because I always forget the intended order of the arguments. But they're still helpful because when we refactor the type we only have the change the logic in one place. Added a regression test.

Instead of LanePriority. Internally, EventPriority is just a lane, so this skips an extra conversion. Since EventPriority is a "public" (to the host config) type, I was also able to remove some deep imports of the Lane module. This gets us most of the way to deleting the LanePriority entirely.

I screwed this up in facebook#21082. Got confused by the < versus > thing again. The helper functions are annoying, too, because I always forget the intended order of the arguments. But they're still helpful because when we refactor the type we only have the change the logic in one place. Added a regression test.

facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Mar 24, 2021

acdlite commented Mar 24, 2021

View reviewed changes

acdlite requested a review from rickhanlonii March 24, 2021 23:54

acdlite marked this pull request as ready for review March 24, 2021 23:54

acdlite force-pushed the event-priority-for-updates branch from 35f87aa to 64284ec Compare March 25, 2021 04:03

acdlite mentioned this pull request Mar 25, 2021

Use Lane to track root callback priority #21089

Merged

acdlite force-pushed the event-priority-for-updates branch from 64284ec to 4b7ff7f Compare March 25, 2021 05:38

acdlite mentioned this pull request Mar 25, 2021

Delete LanePriority type #21090

Merged

6 tasks

rickhanlonii approved these changes Mar 25, 2021

View reviewed changes

acdlite merged commit 03ede83 into facebook:master Mar 25, 2021

acdlite mentioned this pull request Apr 9, 2021

Fix: Event priority of passive effect phase should not be higher than default #21215

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use EventPriority to track update priority #21082

Use EventPriority to track update priority #21082

acdlite commented Mar 24, 2021

acdlite Mar 24, 2021

rickhanlonii Mar 25, 2021

acdlite Mar 25, 2021

sizebot commented Mar 24, 2021 •

edited

Loading

rickhanlonii Mar 25, 2021

rickhanlonii Mar 25, 2021

rickhanlonii Mar 25, 2021

rickhanlonii Mar 25, 2021

rickhanlonii Mar 25, 2021

rickhanlonii Mar 25, 2021

rickhanlonii Mar 25, 2021

rickhanlonii Mar 25, 2021

acdlite Mar 25, 2021

rickhanlonii Mar 25, 2021

acdlite Mar 25, 2021


		let currentUpdatePriority: EventPriority = NoLane;

		export function getCurrentUpdatePriority(): EventPriority {

Use EventPriority to track update priority #21082

Use EventPriority to track update priority #21082

Conversation

acdlite commented Mar 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sizebot commented Mar 24, 2021 • edited Loading

Critical size changes

Significant size changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sizebot commented Mar 24, 2021 •

edited

Loading