Add tests for non-React discrete events flushing in a microtask #20772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm planning to copy paste so why not update them anyway.
These are still using React events. I'll change that next.
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Feb 9, 2021
| // Verify that the second button was removed. | ||
| await null; | ||
| expect(submitButtonRef.current).toBe(null); | ||
| // We'll assume that the browser won't let the user click it. |
There was a problem hiding this comment.
The original test was more interesting here because it fired an event and verified that React ignores it. However, if we fire an event manually on a DOM node, and listen directly on that node with a native listener, it would still fire. So I don't know what we should be testing here. I think just testing that the DOM node was removed is enough because the rest is up to the browser.
gaearon
commented
Feb 9, 2021
| firstEvent.initEvent('click', true, true); | ||
| expect(() => | ||
| dispatchAndSetCurrentEvent(disableButton, firstEvent), | ||
| ).toErrorDev(['An update to Form inside a test was not wrapped in act']); |
There was a problem hiding this comment.
Using act would defeat the point of this test
|
Comparing: 97fce31...f945f3a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
…book#20772) * Convert some old discrete tests to Hooks I'm planning to copy paste so why not update them anyway. * Copy paste discrete tests into another file These are still using React events. I'll change that next. * Convert the test to use native events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some tests for #20748.
They're based on existing tests we have for React events. I converted the old tests to Hooks while I'm at it.
See individual commits.