Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if commit phase error thrown in detached tree #20286

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Warn if commit phase error thrown in detached tree #20286

merged 1 commit into from
Nov 18, 2020

Commits on Nov 18, 2020

  1. Warn if commit phase error thrown in detached tree 

    Until `skipUnmountedBoundaries` lands again, we need some way to detect
when errors are thrown inside a deleted tree. I've added a warning to
`captureCommitPhaseError` that fires when we reach the root of a subtree
without finding either a boundary or a HostRoot.

Even after `skipUnmountedBoundaries`  lands, this warning could be a
useful guard against internal bugs, like a bug in the
`skipUnmountedBoundaries` implementation itself.

In the meantime, do not add this warning to the allowlist; this is only
for our internal use. For this reason, I've also only added it to the
new fork, not the old one, to prevent this from accidentally leaking
into the open source build.
    @acdlite
    acdlite committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    c777f45 View commit details
    Browse the repository at this point in the history