Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkbox toggle for boolean values #19714

Merged
merged 8 commits into from
Sep 3, 2020
Merged

Add checkbox toggle for boolean values #19714

merged 8 commits into from
Sep 3, 2020

Commits on Aug 27, 2020

  1. added a checkbox which appears to the left of the value, when value i… 

    …s boolean
    mdaj06 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    ae69fc1 View commit details
    Browse the repository at this point in the history

  2. removed background colour highlight for checkbox

    mdaj06 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    95b04c5 View commit details
    Browse the repository at this point in the history

  3. checkbox with toggle capability created for boolean props

    mdaj06 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    8946f35 View commit details
    Browse the repository at this point in the history

  4. isValid check is enough for relecting the change in checkBox as it is… 

    … always either true or false
    mdaj06 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    6d41c0a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. created a ref for the checkBox input

    mdaj06 committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    f602074 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. removed ref for check box and put the overrideValueFn function call i… 

    …n the handleCheckBoxToggle function
    mdaj06 committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    3bf56f9 View commit details
    Browse the repository at this point in the history

  2. ran yarn prettier-all

    mdaj06 committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    affe779 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Additional changes 

    * Removed unused inputRef
* Added explanatory inline comment
    @bvaughn
    bvaughn authored Sep 3, 2020
    Configuration menu
    Copy the full SHA
    043b2c4 View commit details
    Browse the repository at this point in the history