Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Render phase update causes remaining updates in same component to be dropped #18537

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Bugfix: Render phase update causes remaining updates in same component to be dropped #18537

merged 2 commits into from
Apr 8, 2020
+161 −7

Commits on Apr 8, 2020

  1. Bugfix: Render phase update leads to dropped work 

    Render phase updates should not affect the `fiber.expirationTime` field.
We don't have to set anything on the fiber because we're going to
process the render phase update immediately.

We also shouldn't reset the `expirationTime` field in between render
passes because it represents the remaining work left in the update
queues. During the re-render, the updates that were skipped in the
original pass are not processed again.

I think my original motivation for using this field for render phase
updates was so I didn't have to add another module level variable.
    @acdlite
    acdlite committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    1bcf7d2 View commit details
    Browse the repository at this point in the history

  2. Add repro case for facebook#18486

    @gaearon @acdlite
    gaearon authored and acdlite committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    d1270e9 View commit details
    Browse the repository at this point in the history