Update react-shallow-renderer from 16.12.0 to 16.13.0 #18185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad810a8:
|
Details of bundled changes.Comparing: 26aa198...ad810a8 react-test-renderer
Size changes (stable) |
Details of bundled changes.Comparing: 26aa198...ad810a8 react-test-renderer
Size changes (experimental) |
NMinhNguyen
commented
Feb 28, 2020
| react-shallow-renderer@^16.13.0: | ||
| version "16.13.0" | ||
| resolved "https://registry.yarnpkg.com/react-shallow-renderer/-/react-shallow-renderer-16.13.0.tgz#18defe59ac922a9623fcbb8bed8db0da7c728fd4" | ||
| integrity sha512-qdFKyjjHSp5t4+Fs4479JqYDQnBdHi/IZEnGEmZZKZqoiwxjG4DKJPYd7YTaTmalUAqZlZR+K9ayz1+8tEctSg== | ||
| dependencies: | ||
| object-assign "^4.1.1" |
There was a problem hiding this comment.
@sebmarkbage I saw your comment (#18127 (review)) about it being good to remove prop-types (CJS dep). Should I also inline an ES version of object-assign?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Published a new version with @gaearon's PR enzymejs/react-shallow-renderer#15 as well as a few cosmetic changes (enzymejs/react-shallow-renderer#14 and enzymejs/react-shallow-renderer#21).
Bundle diff:
https://gist.github.com/NMinhNguyen/11fd4d00bb182e1cf8c8a007ef0df133
Test Plan
CI