Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel parser rather than Babylon in extract errors #17988

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Feb 6, 2020

We broke extract codes at some point, likely when we upgraded Babel. To fix it we should use the @babel/parser package rather than babylon.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 6, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a500eb:

Sandbox Source
blissful-neumann-rdluh Configuration

@sizebot
Copy link

sizebot commented Feb 6, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 4a500eb

@sizebot
Copy link

sizebot commented Feb 6, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 4a500eb

@trueadm trueadm merged commit df134d3 into facebook:master Feb 6, 2020
@trueadm trueadm deleted the fix-extract-codes-build branch February 6, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants