Pass suspense config to startTransition instead of useTransition
#17309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d6db4ec:
|
Details of bundled changes.Comparing: 8e74a31...d6db4ec react-reconciler
react-dom
react-art
react-test-renderer
react-native-renderer
ReactDOM: size: -0.1%, gzip: -0.1% Size changes (stable) |
Details of bundled changes.Comparing: 8e74a31...d6db4ec react-native-renderer
react-test-renderer
react-dom
react-art
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
|
Wanna update the docs? 😄 |
|
j/k. I can do it. |
acdlite
force-pushed
the
pass-suspense-config-to
branch
from
af4855c
to
b5bd7c8
Compare
|
@gaearon Not sure if we've reached consensus on the API change yet, just preparing this PR for when we do. But yeah I was planning to update the docs once it lands :) |
acdlite
force-pushed
the
pass-suspense-config-to
branch
from
b5bd7c8
to
41da7f1
Compare
...instead of `useTransition`. This avoids the problem of having to bind the config object to `startTransition`, invalidating downstream memoizations.
acdlite
force-pushed
the
pass-suspense-config-to
branch
from
41da7f1
to
d6db4ec
Compare
|
Haven't abandoned this. Still need to decide on final API. |
|
Closed by #19703 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the problem of having to bind the config object to
startTransition, invalidating downstream memoizations.See #17284 for more details.
I'll need to codemod the existing callers in www, but that's not a blocker because www uses a userspace fork.