Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind rAF and cAF to window (#16606) #16709

Closed
wants to merge 4 commits into from
Closed

Bind rAF and cAF to window (#16606) #16709

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdde08f
Bind rAF and cAF to window (#16606)
liady Sep 9, 2019
5c6b97d
Prettier
liady Sep 9, 2019
2dc1147
Add a comment in the code
liady Sep 10, 2019
0562fb5
more specific check for function type (rAF and cAF)
liady Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/scheduler/src/forks/SchedulerHostConfig.default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,16 @@ if (
const Date = window.Date;
const setTimeout = window.setTimeout;
const clearTimeout = window.clearTimeout;
const requestAnimationFrame = window.requestAnimationFrame;
const cancelAnimationFrame = window.cancelAnimationFrame;
// Explicitly bind local references to `window`, in order to support
// environments where the global `this` is not the window (e.g extensions)
const requestAnimationFrame =
typeof window.requestAnimationFrame === 'function'
? window.requestAnimationFrame.bind(window)
: undefined;
const cancelAnimationFrame =
typeof window.cancelAnimationFrame === 'function'
? window.cancelAnimationFrame.bind(window)
: undefined;

if (typeof console !== 'undefined') {
// TODO: Remove fb.me link
Expand Down