Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds experimental fundamental interface #16049

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Adds experimental fundamental interface #16049

merged 4 commits into from
Jul 19, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 3, 2019 •
edited
Loading

Note: this is a completely private API for internal experimentation use only. Hydration support will coming in a follow up. The size differences are mostly due to the additional types and symbols added.

@sizebot
Copy link

sizebot commented Jul 3, 2019 •
edited
Loading

React: size: 🔺+0.3%, gzip: 🔺+0.2%

ReactDOM: size: 🔺+0.4%, gzip: 🔺+0.4%

Details of bundled changes.

Comparing: b4178af...cabd05c

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +0.6% +0.5% 112.76 KB 113.49 KB 28.43 KB 28.56 KB UMD_DEV
react.production.min.js 🔺+0.3% 🔺+0.2% 13.22 KB 13.25 KB 5.08 KB 5.09 KB UMD_PROD
react.profiling.min.js +0.2% +0.1% 15.41 KB 15.45 KB 5.63 KB 5.63 KB UMD_PROFILING
react.development.js +1.0% +0.6% 70.26 KB 70.99 KB 18.42 KB 18.53 KB NODE_DEV
react.production.min.js 🔺+0.5% 🔺+0.4% 6.65 KB 6.69 KB 2.74 KB 2.75 KB NODE_PROD
React-dev.js +1.0% +0.6% 68.48 KB 69.18 KB 17.69 KB 17.8 KB FB_WWW_DEV
React-prod.js 🔺+0.3% 🔺+0.3% 17.17 KB 17.21 KB 4.45 KB 4.46 KB FB_WWW_PROD
React-profiling.js +0.3% +0.3% 17.17 KB 17.21 KB 4.45 KB 4.46 KB FB_WWW_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js +0.2% +0.1% 115.06 KB 115.34 KB 36.28 KB 36.31 KB NODE_PROFILING
react-dom-server.browser.development.js +1.1% +0.5% 135.88 KB 137.32 KB 35.88 KB 36.07 KB UMD_DEV
ReactDOM-dev.js +0.9% +0.6% 917.47 KB 925.71 KB 203.6 KB 204.73 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 🔺+0.4% 🔺+0.4% 19.34 KB 19.41 KB 7.23 KB 7.25 KB UMD_PROD
react-dom-test-utils.development.js +0.1% 0.0% 57.96 KB 58 KB 15.91 KB 15.92 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.78 KB 3.78 KB 1.52 KB 1.52 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.95 KB 10.95 KB 4.01 KB 4 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.4% 1.21 KB 1.21 KB 706 B 703 B UMD_PROD
react-dom-test-utils.development.js +0.1% 0.0% 56.22 KB 56.26 KB 15.59 KB 15.6 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.61 KB 3.61 KB 1.48 KB 1.47 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.71 KB 10.71 KB 3.95 KB 3.94 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.05 KB 1.05 KB 637 B 635 B NODE_PROD
react-dom.development.js +0.9% +0.6% 894.56 KB 902.72 KB 203.26 KB 204.39 KB UMD_DEV
react-dom.production.min.js 🔺+0.3% 🔺+0.2% 111.36 KB 111.64 KB 35.86 KB 35.91 KB UMD_PROD
react-dom.profiling.min.js +0.2% 0.0% 114.79 KB 115.07 KB 36.89 KB 36.9 KB UMD_PROFILING
react-dom.development.js +0.9% +0.6% 888.85 KB 897.01 KB 201.75 KB 202.89 KB NODE_DEV
react-dom-server.node.development.js +1.1% +0.6% 133.94 KB 135.38 KB 35.48 KB 35.68 KB NODE_DEV
react-dom.production.min.js 🔺+0.3% 🔺+0.1% 111.42 KB 111.7 KB 35.33 KB 35.38 KB NODE_PROD
react-dom-server.node.production.min.js 🔺+0.3% 🔺+0.3% 20.11 KB 20.18 KB 7.54 KB 7.56 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 371.73 KB 372.07 KB 68.09 KB 68.17 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 377.91 KB 378.23 KB 69.41 KB 69.51 KB FB_WWW_PROFILING
react-dom-server.browser.development.js +1.1% +0.6% 132.01 KB 133.45 KB 34.95 KB 35.14 KB NODE_DEV
react-dom-server.browser.production.min.js 🔺+0.4% 🔺+0.3% 19.26 KB 19.33 KB 7.24 KB 7.26 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.76 KB 60.76 KB 15.85 KB 15.85 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.74 KB 10.74 KB 3.68 KB 3.68 KB UMD_PROD
ReactDOMServer-dev.js +1.2% +0.6% 134.37 KB 135.96 KB 34.5 KB 34.7 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.3% 🔺+0.3% 46.67 KB 46.83 KB 10.74 KB 10.77 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.85 KB 3.85 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.48 KB 10.48 KB 3.58 KB 3.58 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.1 KB 1.1 KB 667 B 665 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +1.0% +0.6% 630.7 KB 637.1 KB 138.14 KB 139.02 KB UMD_DEV
react-art.production.min.js 🔺+0.3% 🔺+0.1% 102.32 KB 102.58 KB 31.32 KB 31.36 KB UMD_PROD
react-art.development.js +1.1% +0.7% 561.55 KB 567.97 KB 120.76 KB 121.65 KB NODE_DEV
react-art.production.min.js 🔺+0.4% 🔺+0.2% 67.37 KB 67.63 KB 20.63 KB 20.68 KB NODE_PROD
ReactART-dev.js +1.1% +0.7% 574.81 KB 581.32 KB 120.29 KB 121.14 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.2% 🔺+0.2% 218.7 KB 219.04 KB 37.12 KB 37.2 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.2% 272.14 KB 272.55 KB 46.7 KB 46.77 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.1% +0.2% 280.75 KB 281.15 KB 48.28 KB 48.36 KB RN_OSS_PROFILING
ReactFabric-prod.js 0.0% 0.0% 266.24 KB 266.36 KB 45.83 KB 45.86 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 275.04 KB 275.14 KB 47.32 KB 47.34 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.9% +0.5% 722.51 KB 729.08 KB 153.25 KB 154.07 KB RN_FB_DEV
ReactFabric-prod.js 0.0% 0.0% 266.25 KB 266.36 KB 45.85 KB 45.87 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.9% +0.5% 708.94 KB 715.44 KB 150.64 KB 151.46 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% 0.0% 275.04 KB 275.14 KB 47.33 KB 47.35 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js +0.9% +0.5% 709.03 KB 715.54 KB 150.69 KB 151.51 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.2% 272.14 KB 272.54 KB 46.71 KB 46.78 KB RN_FB_PROD
ReactNativeRenderer-profiling.js +0.1% +0.2% 280.74 KB 281.14 KB 48.28 KB 48.37 KB RN_FB_PROFILING
ReactFabric-dev.js +0.9% +0.5% 722.4 KB 728.97 KB 153.21 KB 154.02 KB RN_OSS_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +1.3% +0.8% 584.73 KB 592.36 KB 122.64 KB 123.63 KB FB_WWW_DEV
react-test-renderer-shallow.development.js +0.1% +0.1% 41.46 KB 41.5 KB 10.78 KB 10.79 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.66 KB 11.66 KB 3.56 KB 3.56 KB UMD_PROD
react-test-renderer-shallow.development.js +0.1% +0.1% 35.6 KB 35.64 KB 9.41 KB 9.42 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 11.8 KB 11.8 KB 3.68 KB 3.68 KB NODE_PROD
react-test-renderer.development.js +1.3% +0.8% 573.91 KB 581.44 KB 123.44 KB 124.46 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.3% 🔺+0.1% 68.73 KB 68.94 KB 21.09 KB 21.11 KB UMD_PROD
react-test-renderer.development.js +1.3% +0.8% 569.45 KB 576.98 KB 122.3 KB 123.34 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.4% 🔺+0.4% 68.44 KB 68.68 KB 20.84 KB 20.92 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +1.1% +0.7% 559.76 KB 566.14 KB 119.29 KB 120.18 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.3% 🔺+0.4% 68.62 KB 68.85 KB 20.42 KB 20.5 KB NODE_PROD
react-reconciler-reflection.development.js +0.6% +0.5% 18.66 KB 18.78 KB 6.03 KB 6.06 KB NODE_DEV
react-reconciler-reflection.production.min.js 🔺+0.5% 🔺+0.3% 2.58 KB 2.59 KB 1.13 KB 1.14 KB NODE_PROD
react-reconciler-persistent.development.js +1.1% +0.8% 557.35 KB 563.68 KB 118.23 KB 119.12 KB NODE_DEV
react-reconciler-persistent.production.min.js 🔺+0.3% 🔺+0.4% 68.63 KB 68.86 KB 20.43 KB 20.5 KB NODE_PROD

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer-server.development.js 0.0% -0.2% 1.83 KB 1.83 KB 877 B 875 B NODE_DEV
react-noop-renderer-server.production.min.js 0.0% -0.4% 813 B 813 B 491 B 489 B NODE_PROD
react-noop-renderer-persistent.development.js +6.3% +2.8% 36.98 KB 39.29 KB 9.26 KB 9.51 KB NODE_DEV
react-noop-renderer-persistent.production.min.js 🔺+6.8% 🔺+4.2% 11.13 KB 11.89 KB 3.58 KB 3.73 KB NODE_PROD
react-noop-renderer.development.js +6.3% +2.8% 36.86 KB 39.17 KB 9.24 KB 9.5 KB NODE_DEV
react-noop-renderer.production.min.js 🔺+6.9% 🔺+4.3% 11.11 KB 11.87 KB 3.57 KB 3.73 KB NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm force-pushed the fundamental-experiment branch 2 times, most recently from c734419 to a62db54 Compare July 3, 2019 18:21
@trueadm
Adds experimental fundamental interface
1fadc8d 
Add flag to more areas to reduce bundle size

Fix persistence mode

Disable flags

Add more tests and functionality

Revise naming

WIP
@trueadm trueadm force-pushed the fundamental-experiment branch from a62db54 to 1fadc8d Compare July 3, 2019 18:30
@trueadm
Copy link
Contributor Author

trueadm commented Jul 12, 2019

@acdlite @sebmarkbage would be good to have a review on the core changes please?

@trueadm trueadm merged commit 2c4d61e into facebook:master Jul 19, 2019
@trueadm trueadm deleted the fundamental-experiment branch July 19, 2019 21:20
@miraage
Copy link

miraage commented Dec 11, 2019

Hey guys,

Browsing React sources led me to this PR.
I would be happy to know what this API about.

Cheers

@darwin darwin mentioned this pull request Jan 22, 2020
Closed
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
@trueadm
Adds experimental fundamental interface (#16049)
3ca7eaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

@necolas necolas necolas approved these changes

@threepointone threepointone Awaiting requested review from threepointone

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trueadm @sizebot @miraage @necolas @acdlite @facebook-github-bot