React events: Press event fixes #15386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 9672cf6...2f6ab3e react-events
Generated by 🚫 dangerJS |
trueadm
reviewed
Apr 11, 2019
packages/react-events/src/Press.js
Outdated
| if (nativeEvent.pointerType != null) { | ||
| return nativeEvent.pointerType; | ||
| } | ||
| if (nativeEvent.type.indexOf('mouse') > -1) { |
There was a problem hiding this comment.
Could type be pulled out to its own variable? Seems like a lot of property accesses each time otherwise and should reduce prod code size.
trueadm
approved these changes
Apr 11, 2019
necolas
force-pushed
the
react-events/misc-fixes
branch
from
60439f7 to
f08ce74
Compare
necolas
force-pushed
the
react-events/misc-fixes
branch
from
f08ce74 to
2f6ab3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointerTypeto Press events.NOTE: this currently extends
pointerTypewith non-standard types. We could consider using a different name, likeinputModeor something.NOTE: React Native doesn't have a deactivation delay for forced activation, but this is possibly because of the async bridge meaning that the events aren't dispatched sync.
Ref #15257