Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular module imports causing file size increase #15231

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 28, 2019

This PR is a follow up to #15228, where the PR increased the size of the bundle with flags due to a cyclic module reference that somehow caused Rollup/GCC to not optimize the output as well. This PR contains a work around that restores the bundle size to the original size.

@sizebot
Copy link

sizebot commented Mar 28, 2019

ReactDOM: size: -0.1%, gzip: -0.3%

Details of bundled changes.

Comparing: 669cafb...41587cc

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% -0.0% 812.66 KB 813.02 KB 184.2 KB 184.14 KB UMD_DEV
react-dom.production.min.js -0.1% -0.3% 105.18 KB 105.12 KB 34.07 KB 33.97 KB UMD_PROD
react-dom.profiling.min.js -0.1% -0.1% 108.16 KB 108.09 KB 34.68 KB 34.63 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 807.05 KB 807.41 KB 182.61 KB 182.54 KB NODE_DEV
react-dom.production.min.js -0.1% -0.1% 105.16 KB 105.09 KB 33.52 KB 33.48 KB NODE_PROD
react-dom.profiling.min.js -0.1% -0.2% 108.26 KB 108.19 KB 34.15 KB 34.08 KB NODE_PROFILING
ReactDOM-dev.js 0.0% -0.1% 831.75 KB 832.11 KB 184.27 KB 184.17 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% 🔺+0.1% 330.98 KB 330.96 KB 60.9 KB 60.97 KB FB_WWW_PROD
ReactDOM-profiling.js -0.0% +0.1% 337.36 KB 337.35 KB 62.26 KB 62.33 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js 0.0% -0.0% 813 KB 813.36 KB 184.34 KB 184.28 KB UMD_DEV
react-dom-unstable-fire.production.min.js -0.1% -0.3% 105.2 KB 105.13 KB 34.08 KB 33.98 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js -0.1% -0.1% 108.17 KB 108.11 KB 34.68 KB 34.64 KB UMD_PROFILING
react-dom-unstable-fire.development.js 0.0% -0.0% 807.39 KB 807.75 KB 182.75 KB 182.68 KB NODE_DEV
react-dom-unstable-fire.production.min.js -0.1% -0.1% 105.18 KB 105.11 KB 33.53 KB 33.49 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js -0.1% -0.2% 108.28 KB 108.21 KB 34.16 KB 34.09 KB NODE_PROFILING
ReactFire-dev.js 0.0% -0.0% 830.96 KB 831.32 KB 184.17 KB 184.1 KB FB_WWW_DEV
ReactFire-prod.js -0.1% -0.1% 320.08 KB 319.62 KB 58.72 KB 58.65 KB FB_WWW_PROD
ReactFire-profiling.js -0.1% -0.2% 326.41 KB 325.95 KB 60.09 KB 60 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% 0.0% 47.49 KB 47.49 KB 12.98 KB 12.98 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 9.95 KB 9.95 KB 3.66 KB 3.66 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.74 KB 60.74 KB 15.84 KB 15.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.69 KB 10.69 KB 3.67 KB 3.67 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.41 KB 60.41 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-server.browser.development.js 0.0% 0.0% 133.68 KB 133.68 KB 35.37 KB 35.38 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 18.93 KB 18.93 KB 7.14 KB 7.14 KB UMD_PROD
react-dom-server.browser.development.js 0.0% 0.0% 129.81 KB 129.81 KB 34.43 KB 34.43 KB NODE_DEV
ReactDOMServer-prod.js 0.0% -0.0% 45.67 KB 45.67 KB 10.57 KB 10.56 KB FB_WWW_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 19.72 KB 19.72 KB 7.44 KB 7.44 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.66 KB 3.66 KB 1.45 KB 1.45 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.21 KB 1.21 KB 705 B 706 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.49 KB 3.49 KB 1.41 KB 1.41 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 636 B 637 B NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.1% 1.1 KB 1.1 KB 667 B 668 B NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit 1cfd256 into facebook:master Mar 28, 2019
@trueadm trueadm deleted the fix-size-increase branch March 28, 2019 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants