Code

Enable getDerivedStateFromError#13746

Code

Merged

bvaughn merged 10 commits intofacebook:masterfacebook/react:masterfrom bvaughn:getDerivedStateFromCatchbvaughn/react:getDerivedStateFromCatchCopy head branch name to clipboardSep 28, 2018

+2,639-242

Commits

Commits on Sep 27, 2018

• Removed the enableGetDerivedStateFromCatch feature flag (aka permanently enabled the feature)

  

  Brian Vaughn

  committed
  4ed84b0

  Copy full SHA for 4ed84b0

• Forked/copied ReactErrorBoundaries to ReactLegacyErrorBoundaries for testing componentDidCatch

  

  Brian Vaughn

  committed
  cd49672

  Copy full SHA for cd49672

• Updated error boundaries tests to apply to getDerivedStateFromCatch and fixed a minor reconciliation error in begin work.

  

  Brian Vaughn

  committed
  56bbf1c

  Copy full SHA for 56bbf1c

• Renamed getDerivedStateFromCatch -> getDerivedStateFromError

  

  Brian Vaughn

  committed
  f6fb111

  Copy full SHA for f6fb111

• Warn if boundary with only componentDidCatch swallows error

  

  Brian Vaughn

  committed
  3df17ba

  Copy full SHA for 3df17ba

Commits on Sep 28, 2018

• Changed componentDidCatch state-update detection logic based on feedback from Andrew

  

  Brian Vaughn

  committed
  233459a

  Copy full SHA for 233459a

• Updated a few tests to account for a new DEV warning

  

  Brian Vaughn

  committed
  9943c6c

  Copy full SHA for 9943c6c

• Changed componentDidCatch no-state-update warning message to remove mention of throw

  Show description for 54f637f
  

  Brian Vaughn

  committed
  54f637f

  Copy full SHA for 54f637f

• Force remount children by reconciling against an empty set

  acdlite

  committed
  574f68e

  Copy full SHA for 574f68e

• Add incremental error test

  acdlite

  committed
  f1171b7

  Copy full SHA for f1171b7