Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Flow typings from Schedule.js #13662

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Conversation

alexeyraspopov
Copy link
Contributor

As described in #13582, this file needs to be as close to ES5 as possible. Flow pragma (@flow) was deleted but there was still a single function signature. Removing it in this PR.

Not sure about what should be done to the export statement in the end though.

@sizebot
Copy link

sizebot commented Sep 15, 2018

Details of bundled changes.

Comparing: d92114b...73e9081

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@gaearon
Copy link
Collaborator

gaearon commented Sep 15, 2018

We want to keep export / import since that part would be necessary for ESM. We'll just compile it alone for UMD later.

@gaearon gaearon merged commit 1d8a75f into facebook:master Sep 15, 2018
@gaearon
Copy link
Collaborator

gaearon commented Sep 15, 2018

We should probably tweak this to do the checking for us.
https://github.com/facebook/react/blob/master/scripts/shared/pathsByLanguageVersion.js

@NE-SmallTown
Copy link
Contributor

NE-SmallTown commented Sep 15, 2018

We should probably tweak this to do the checking for us.

You mean add 'packages/schedule/src/*.js' to es5Paths in pathsByLanguageVersion.js?

We'll just compile it alone for UMD later.

But the main field of the package.json of schedule refer to './src/index' rather than './npm/index', I'm a little confused here

gaearon added a commit that referenced this pull request Sep 17, 2018
Simek pushed a commit to Simek/react that referenced this pull request Oct 25, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants