Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop handling for ms and O prefixes for CSS transition and animation events. #13133

Merged

Conversation

realityking
Copy link
Contributor

I think the Moz prefix could be dropped as well. It's only needed by Firefox 15 and older. This could open up a small refactor avoiding building these maps. WDYT?

…events.

Internet Explorer never needed the prefix and Opera 11.5 is no longer supported by React.
@gaearon
Copy link
Collaborator

gaearon commented Jul 4, 2018

I don't feel comfortable dropping -ms- events without manual testing. Even caniuse is not guaranteed to be 100% accurate.

We’d need to test that all specific events in the list in this file either don't fire at all, or fire without a prefix, in every version after and including IE9.

@realityking
Copy link
Contributor Author

realityking commented Jul 4, 2018

That's fair. I took a slightly different approach to confirm it, I hope that works

First, Internet Explorer 9 is not an issue as it neither supports CSS Transitions nor CSS Animations.

Secondly, I created a file that contains the getVendorPrefixedEventName() code changed to be ES5 code and hosted it on GitHub pages (https://realityking.github.io/ie-css-event-test/).

Next I use the screenshot tool from Microsoft and BrowserStack to see what different IE put out for this code. You can see the result here https://developer.microsoft.com/en-us/microsoft-edge/tools/screenshots/?url=https%3A%2F%2Frealityking.github.io%2Fie-css-event-test%2F

Result: Both IE 10 and IE 11 use the unprefixed events.

@gaearon gaearon merged commit 07fefe3 into facebook:master Jul 4, 2018
@gaearon
Copy link
Collaborator

gaearon commented Jul 4, 2018

OK, this seems reasonable. Thanks.

@realityking realityking deleted the simplify-vendor-prefixed-events branch July 4, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants