-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to 'setTimeout' when 'requestAnimationFrame' is not called #13091
Merged
flarnie
merged 3 commits into
facebook:master
from
flarnie:fixRenderingAsyncInBackgroundedTab
Jun 22, 2018
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,6 +117,7 @@ if (!canUseDOM) { | |
}; | ||
} else { | ||
const localRequestAnimationFrame = requestAnimationFrame; | ||
const localCancelAnimationFrame = cancelAnimationFrame; | ||
|
||
let headOfPendingCallbacksLinkedList: CallbackConfigType | null = null; | ||
let tailOfPendingCallbacksLinkedList: CallbackConfigType | null = null; | ||
|
@@ -128,6 +129,27 @@ if (!canUseDOM) { | |
let isIdleScheduled = false; | ||
let isAnimationFrameScheduled = false; | ||
|
||
// requestAnimationFrame does not run when the tab is in the background. | ||
// if we're backgrounded we prefer for that work to happen so that the page | ||
// continues to load in the background. | ||
// so we also schedule a 'setTimeout' as a fallback. | ||
const animationFrameTimeout = 100; | ||
let rafID; | ||
let timeoutID; | ||
const scheduleAnimationFrameWithFallbackSupport = function(callback) { | ||
// schedule rAF and also a setTimeout | ||
rafID = localRequestAnimationFrame(function(...args) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: We expect a single argument, let's keep that explicit? Even if we changed to many, the other if branch already assumes it's just one, so might as well do here for clarity |
||
// cancel the setTimeout | ||
localClearTimeout(timeoutID); | ||
callback(...args); | ||
}); | ||
timeoutID = localSetTimeout(function() { | ||
// cancel the requestAnimationFrame | ||
localCancelAnimationFrame(rafID); | ||
callback(now()); | ||
}, animationFrameTimeout); | ||
}; | ||
|
||
let frameDeadline = 0; | ||
// We start out assuming that we run at 30fps but then the heuristic tracking | ||
// will adjust this value to a faster fps if we get more frequent animation | ||
|
@@ -266,7 +288,7 @@ if (!canUseDOM) { | |
if (!isAnimationFrameScheduled) { | ||
// Schedule another animation callback so we retry later. | ||
isAnimationFrameScheduled = true; | ||
localRequestAnimationFrame(animationTick); | ||
scheduleAnimationFrameWithFallbackSupport(animationTick); | ||
} | ||
} | ||
}; | ||
|
@@ -347,7 +369,7 @@ if (!canUseDOM) { | |
// might want to still have setTimeout trigger scheduleWork as a backup to ensure | ||
// that we keep performing work. | ||
isAnimationFrameScheduled = true; | ||
localRequestAnimationFrame(animationTick); | ||
scheduleAnimationFrameWithFallbackSupport(animationTick); | ||
} | ||
return scheduledCallbackConfig; | ||
}; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 100?Sorry. I'll keep reading :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question~! It's arbitrary - seemed like enough time to have lots of numbers increment, but not too fast to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I didn't know about the scheduling fixtures! This is really neat!