-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add es3ify to JSX transform #1224
Conversation
I'm mostly certain we're not going to do this as is internally, so will probably need to shuffle around a little bit. Will talk with @jeffmo |
@zpao Why not? Surely you guys don't want to worry about quoting your reserved keys for IE8. |
We may already be quoting these in a different transform internally but I don't know. Also, even if we aren't, we can't just copy-paste, visitor list set up is different. Tangential but does |
Yeah. |
This would make facebook#1223 easier to deal with in older browsers. With this change, <div class="orange" /> compiles into React.DOM.div( {"class":"orange"} ); and `this.props.class` turns into `this.props["class"]`.
Hmm, I guess the keywords that need to be quoted already aren't getting crushed by closure compiler so I guess that's ok. |
This would make #1223 easier to deal with in older browsers.
With this change,
compiles into
and
this.props.class
turns intothis.props["class"]
.