Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing single-word attributes to property warning list #10495

Merged
merged 5 commits into from
Aug 21, 2017
Merged

Add missing single-word attributes to property warning list #10495

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64008e7
Add missing single-word attributes to property warning list
nhunzaker Aug 18, 2017
0ccbe71
Alphabetize svg and html configs in possible names
nhunzaker Aug 18, 2017
de06c4a
Add basic test coverage for known single word attributes
nhunzaker Aug 18, 2017
77861ec
Add note about including whitelist properites in `possibleStandardNames
nhunzaker Aug 18, 2017
37608e5
Also add attribute sync comment to possibleStandardNames
nhunzaker Aug 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 184 additions & 0 deletions src/renderers/dom/shared/hooks/possibleStandardNames.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,190 @@ var possibleStandardNames = {
xmlspace: 'xmlSpace',
ychannelselector: 'yChannelSelector',
zoomandpan: 'zoomAndPan',
accept: 'accept',
action: 'action',
alt: 'alt',
as: 'as',
async: 'async',
capture: 'capture',
challenge: 'challenge',
checked: 'checked',
cite: 'cite',
cols: 'cols',
content: 'content',
controls: 'controls',
coords: 'coords',
data: 'data',
default: 'default',
defer: 'defer',
dir: 'dir',
disabled: 'disabled',
download: 'download',
draggable: 'draggable',
form: 'form',
headers: 'headers',
height: 'height',
hidden: 'hidden',
high: 'high',
href: 'href',
icon: 'icon',
id: 'id',
integrity: 'integrity',
is: 'is',
kind: 'kind',
label: 'label',
lang: 'lang',
list: 'list',
loop: 'loop',
low: 'low',
manifest: 'manifest',
max: 'max',
media: 'media',
method: 'method',
min: 'min',
multiple: 'multiple',
muted: 'muted',
name: 'name',
nonce: 'nonce',
open: 'open',
optimum: 'optimum',
pattern: 'pattern',
placeholder: 'placeholder',
poster: 'poster',
preload: 'preload',
profile: 'profile',
rel: 'rel',
required: 'required',
reversed: 'reversed',
role: 'role',
rows: 'rows',
sandbox: 'sandbox',
scope: 'scope',
scoped: 'scoped',
scrolling: 'scrolling',
seamless: 'seamless',
selected: 'selected',
shape: 'shape',
size: 'size',
sizes: 'sizes',
span: 'span',
src: 'src',
start: 'start',
step: 'step',
style: 'style',
summary: 'summary',
target: 'target',
title: 'title',
type: 'type',
value: 'value',
width: 'width',
wmode: 'wmode',
wrap: 'wrap',
about: 'about',
datatype: 'datatype',
inlist: 'inlist',
prefix: 'prefix',
property: 'property',
resource: 'resource',
typeof: 'typeof',
vocab: 'vocab',
color: 'color',
results: 'results',
security: 'security',
unselectable: 'unselectable',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we start from A three times? Are these generated from different whitelists? In this case should there be a comment explaining grouping
Or we could sort them all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's a combination of the HTML Property Config and SVG Property Config, which where ultimately just blended into the same list inside of DOMProperty.properties

Wrestled with some editor-fu, but I've alphabetized these while still clumping together aliases.

accumulate: 'accumulate',
additive: 'additive',
alphabetic: 'alphabetic',
amplitude: 'amplitude',
ascent: 'ascent',
azimuth: 'azimuth',
bbox: 'bbox',
begin: 'begin',
bias: 'bias',
by: 'by',
clip: 'clip',
cursor: 'cursor',
cx: 'cx',
cy: 'cy',
d: 'd',
decelerate: 'decelerate',
descent: 'descent',
direction: 'direction',
display: 'display',
divisor: 'divisor',
dur: 'dur',
dx: 'dx',
dy: 'dy',
elevation: 'elevation',
end: 'end',
exponent: 'exponent',
fill: 'fill',
filter: 'filter',
focusable: 'focusable',
format: 'format',
from: 'from',
fx: 'fx',
fy: 'fy',
g1: 'g1',
g2: 'g2',
hanging: 'hanging',
ideographic: 'ideographic',
in: 'in',
in2: 'in2',
intercept: 'intercept',
k: 'k',
k1: 'k1',
k2: 'k2',
k3: 'k3',
k4: 'k4',
kerning: 'kerning',
local: 'local',
mask: 'mask',
mathematical: 'mathematical',
mode: 'mode',
offset: 'offset',
opacity: 'opacity',
operator: 'operator',
order: 'order',
orient: 'orient',
orientation: 'orientation',
origin: 'origin',
overflow: 'overflow',
panose1: 'panose1',
points: 'points',
r: 'r',
radius: 'radius',
restart: 'restart',
result: 'result',
rotate: 'rotate',
rx: 'rx',
ry: 'ry',
scale: 'scale',
seed: 'seed',
slope: 'slope',
spacing: 'spacing',
speed: 'speed',
stemh: 'stemh',
stemv: 'stemv',
string: 'string',
stroke: 'stroke',
to: 'to',
transform: 'transform',
u1: 'u1',
u2: 'u2',
unicode: 'unicode',
values: 'values',
version: 'version',
visibility: 'visibility',
widths: 'widths',
x: 'x',
x1: 'x1',
x2: 'x2',
xmlns: 'xmlns',
y: 'y',
y1: 'y1',
y2: 'y2',
z: 'z',
};

module.exports = possibleStandardNames;