Fix boolean attributes as per HTML5 spec #1005
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was simpler to just start a new branch than to fix my commit mangling. |
| @@ -95,6 +95,9 @@ var DOMPropertyOperations = { | |||
| return ''; | |||
| } | |||
| var attributeName = DOMProperty.getAttributeName[name]; | |||
| if (value && DOMProperty.hasBooleanValue[name]) { | |||
There was a problem hiding this comment.
We've already determined that value is truthy (see shouldIgnoreValue) so I think we can get rid of that check.
There was a problem hiding this comment.
@zpao Right, that makes sense. Fixed.
zpao
added a commit
that referenced
this pull request
Feb 4, 2014
Fix boolean attributes as per HTML5 spec
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.