Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft Edge - Has textInput event fires twice during ctrl-a selection + keypress and crashes Draft-JS #7269

Closed
butchmarshall opened this issue Jul 13, 2016 · 1 comment
Closed

Microsoft Edge - Has textInput event fires twice during ctrl-a selection + keypress and crashes Draft-JS #7269

butchmarshall opened this issue Jul 13, 2016 · 1 comment

Comments

@butchmarshall
Copy link

butchmarshall commented Jul 13, 2016 •
edited
Loading

This issue was discovered while building an editor in Draft-JS (see original issue filed here)

Edge provides a TextEvent - but it's still not useful. Disabling canUseTextInputEvent in React for Edge fixes the Draft-JS issue.

To reproduce the bug in Draft-JS:

Go to https://facebook.github.io/draft-js
type "a"
hit enter
type ctrl-a to select everything
type "j"

You'll get a javascript error. The editor (actually, the ReactDomComponent) is then in a confused state.

The DOM component that the react component points to is prematurely removed.
@butchmarshall butchmarshall mentioned this issue Jul 13, 2016
Open
butchmarshall added a commit to butchmarshall/react that referenced this issue Jul 13, 2016
@butchmarshall
Issue facebook#7269
8fa8bf3 
Microsoft Edge exposes TextInput event, but it's not useful either.
@butchmarshall butchmarshall mentioned this issue Jul 13, 2016
Closed
@butchmarshall butchmarshall changed the title Microsoft Edge - Has textInput event but it's not useful and crashes Draft-JS Microsoft Edge - Has textInput event fires twice during ctrl-a selection + keypress and crashes Draft-JS Jul 13, 2016
@jdalton
Copy link
Contributor

jdalton commented Nov 8, 2016

I can't repro this on the insider preview of Edge 15.

@colinjeanne colinjeanne mentioned this issue Jan 27, 2017
Closed
@gaearon gaearon closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdalton @butchmarshall @gaearon