Minified version broken in IE8 #2247

cascadian · 2014-09-26T05:31:46Z

line 66 of setInnerHTML node.innerHTML = '\uFEFF' + html; is minified as e.innerHTML = "" + t; in react.min.js and react-with-addons.min.js. An exception is thrown on on line 71 because textNode.data is undefined.

Here's a repro that's modified from the basic example

    <script src="../../build/react.min.js"></script>
    <script>
      var Container = React.createClass({
        render: function(){
          return React.DOM.div(null, this.props.children);
        }
      });
      var ExampleApplication = React.createClass({
        render: function() {
          var elapsed = Math.round(this.props.elapsed  / 100);
          var seconds = elapsed / 10 + (elapsed % 10 ? '' : '.0' );
          var message =
            'React has been successfully running for ' + seconds + ' seconds.';

          return React.DOM.p(null, message);
        }
      });
        React.renderComponent(
          Container(null,
            ExampleApplication({elapsed: new Date().getTime()}),
          document.getElementById('container')
        ));

    </script>

The text was updated successfully, but these errors were encountered:

sophiebits · 2014-09-26T05:38:23Z

What encoding are you serving your HTML with? My guess is if you add <meta charset="utf-8"> to your <head> then this will work correctly, though maybe we should use only ASCII chars in our minified builds.

sophiebits · 2014-09-26T05:42:01Z

Never mind, I see that the character is actually missing. Maybe a bug in uglifyjs?

syranide · 2014-09-26T08:50:35Z

@spicyj As it's encoded the charset is irrelevant unless uglifyjs decodes it, being zero-width/invisible I imagine it would look like nothing is there... but it really seems like nothing is there. Very weird.

syranide · 2014-09-26T08:56:18Z

https://github.com/mishoo/UglifyJS2/blob/master/lib/parse.js#L209

Is apparently the culprit, but it doesn't seem like it should be. Perhaps uglifyjs decodes strings first and then strips for some reason...

syranide · 2014-09-26T09:09:23Z

mishoo/UglifyJS#556

syranide · 2014-09-26T09:19:45Z

Hmm, this is interesting, this problem only surfaces if you double-uglify the source, perhaps something is wrong in our build-process?

syranide · 2014-09-26T09:59:08Z

PR #2249

syranide · 2014-09-26T13:18:47Z

@cascadian I should add; if this is a priority for you simply replace .innerHTML="" with .innerHTML="!" (you can replace "\uFEFF" with "!" in the source too) and it should work.

zpao · 2014-09-29T19:05:49Z

this problem only surfaces if you double-uglify the source, perhaps something is wrong in our build-process

Yes, we double uglify to remove dead requires from the tree (see #1933).

dennis-johnson-dev · 2014-12-18T22:06:20Z

Is this still an issue? I'm seeing it with react-with-addons.min.js v 0.12.2 in IE8.

syranide · 2015-01-04T23:59:08Z

Ping, this is resolved in uglifyjs/master now at least. React should go the way of #2340 if you ask me though.

markplindsay · 2015-03-17T14:30:36Z

This issue, although easily fixed by @syranide's DIY patch, still exists in http://fb.me/react-0.13.1.min.js and any other FB-packaged react.min.js. :| Sorry to be a nag. In the end this is all IE8's fault anyway.

syranide · 2015-03-17T14:34:23Z

@markplindsay I haven't verified, but this was fixed upstream in UglifyJS some time ago so it should have solved itself... @zpao is it possible you're running the build process with an older UglifyJS?

markplindsay · 2015-03-17T14:40:43Z

@syranide, thanks for your followup. I am looking at a react-0.13.1.min.js I wgot from http://fb.me/react-0.13.1.min.js. Changing e.innerHTML="" to e.innerHTML="!" by adding the ! at Line 15, Column 17852 still fixes the issue.

syranide · 2015-03-17T14:45:00Z

@zpao Ah, apparently we've locked the uglifyjs dependency to 2.4.0 whereas the fix is in 2.4.17 (or perhaps the one after it, not sure what the tag means in mishoo/UglifyJS@24bc09b). There's no reason not to update the dependency right?

mockdeep · 2015-04-10T18:53:40Z

We just got bit by this issue. Please update uglify!

sophiebits · 2015-04-10T19:26:39Z

AFAIK no reason not to upgrade. @syranide want to send a PR to the 0.13-stable branch? (I forget how to update shrinkwrap files properly though…)

zpao · 2015-04-10T19:30:54Z

Send to master and I'll pull it in with other things

cheers,
Paul

On Apr 10, 2015, at 12:26 PM, Ben Alpert <[email protected]mailto:[email protected]> wrote:

AFAIK no reason not to upgrade. @syranidehttps://github.com/syranide want to send a PR to the 0.13-stable branch? (I forget how to update shrinkwrap files properly though…)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2247#issuecomment-91658188.

Apparently we needed to get to v2.4.17 to get the fix for facebook#2247. We shrinkwrapped on the same day but the timing didn't work out so we missed it.

zpao · 2015-04-13T22:44:38Z

Just confirmed that this is correct in the minified build now. We'll ship 0.13.2 this week with the fix.

ledowong · 2015-04-14T11:39:48Z

will 0.12.x get rebuild too?

sophiebits · 2015-04-14T20:35:08Z

@ledowong No, we don't generally do point releases except for the newest minor release except in the case of a security vulnerability. You can patch in the change locally and make your own build of 0.12 if you're unable to upgrade to 0.13.

sophiebits added the Type: Bug label Sep 26, 2014

syranide mentioned this issue Sep 26, 2014

Replace '\uFEFF' with '!' for setInnerHTML to avoid UglifyJS bug #2249

Closed

syranide mentioned this issue Sep 26, 2014

"\uFEFF" in strings removed, breaks React build. mishoo/UglifyJS#556

Closed

syranide mentioned this issue Oct 13, 2014

Replace setInnerHTML with Danger.dangerouslyUpdateInnerHTML, uses createNodesFromMarkup #2340

Closed

2 tasks

syranide mentioned this issue Nov 14, 2014

"data.length is null" error when set innerHTML (which has comment nodes) in IE-8 (only happens in compressed version) #2525

Closed

zpao added a commit to zpao/react that referenced this issue Apr 13, 2015

Update uglify dependency

d467b52

Apparently we needed to get to v2.4.17 to get the fix for facebook#2247. We shrinkwrapped on the same day but the timing didn't work out so we missed it.

zpao mentioned this issue Apr 13, 2015

Update uglify dependency #3662

Merged

zpao closed this as completed Apr 13, 2015

snyk-bot mentioned this issue Jun 21, 2021

[Snyk] Security upgrade web-ext from 5.5.0 to 6.2.0 ryan-ally/react-1#64

Open

This was referenced Jun 22, 2021

[Snyk] Security upgrade web-ext from 4.3.0 to 6.2.0 andygongea/react#62

Open

[Snyk] Security upgrade web-ext from 4.3.0 to 6.2.0 nchathu2014/react#14

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minified version broken in IE8 #2247

Minified version broken in IE8 #2247

cascadian commented Sep 26, 2014

sophiebits commented Sep 26, 2014

sophiebits commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

zpao commented Sep 29, 2014

dennis-johnson-dev commented Dec 18, 2014

syranide commented Jan 4, 2015

markplindsay commented Mar 17, 2015

syranide commented Mar 17, 2015

markplindsay commented Mar 17, 2015

syranide commented Mar 17, 2015

mockdeep commented Apr 10, 2015

sophiebits commented Apr 10, 2015

zpao commented Apr 10, 2015

zpao commented Apr 13, 2015

ledowong commented Apr 14, 2015

sophiebits commented Apr 14, 2015

Minified version broken in IE8 #2247

Minified version broken in IE8 #2247

Comments

cascadian commented Sep 26, 2014

sophiebits commented Sep 26, 2014

sophiebits commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

syranide commented Sep 26, 2014

zpao commented Sep 29, 2014

dennis-johnson-dev commented Dec 18, 2014

syranide commented Jan 4, 2015

markplindsay commented Mar 17, 2015

syranide commented Mar 17, 2015

markplindsay commented Mar 17, 2015

syranide commented Mar 17, 2015

mockdeep commented Apr 10, 2015

sophiebits commented Apr 10, 2015

zpao commented Apr 10, 2015

zpao commented Apr 13, 2015

ledowong commented Apr 14, 2015

sophiebits commented Apr 14, 2015