Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: The tag <webview> is unrecognized in this browser #13299

Closed
mhuggins opened this issue Aug 1, 2018 · 4 comments
Closed

Warning: The tag <webview> is unrecognized in this browser #13299

mhuggins opened this issue Aug 1, 2018 · 4 comments

Comments

@mhuggins
Copy link
Contributor

mhuggins commented Aug 1, 2018

Do you want to request a feature or report a bug?
Bug (for electron users)

What is the current behavior?
When running jest, if any components containing a webview element are rendered, a warning is rendered to the console. When many tests are run, the output is littered with warnings.

console.error node_modules/fbjs/lib/warning.js:33
  Warning: The tag <webview> is unrecognized in this browser. If you meant to render a React component, start its name with an uppercase letter.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:
https://jsfiddle.net/Luktwrdm/859/

What is the expected behavior?
No warning is logged to the console.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React: 16.4.1
Electron: 2.0.6
Unknown if it worked in prior versions of react.

@gaearon
Copy link
Collaborator

gaearon commented Aug 1, 2018

What other special tags does Electron have?

@philipp-spiess
Copy link
Contributor

Looking through their docs it seems to be only the <webview> tag for now: https://electronjs.org/docs/all#custom-dom-elements

@gaearon
Copy link
Collaborator

gaearon commented Aug 1, 2018

In that case I don’t mind adding it to the whitelist. Send a PR?

philipp-spiess added a commit to philipp-spiess/react that referenced this issue Aug 1, 2018
Fixes facebook#13299

Adds Electrons <webview> tag to the attribute whitelist.
gaearon pushed a commit that referenced this issue Aug 1, 2018
Fixes #13299

Adds Electrons <webview> tag to the attribute whitelist.
@mhuggins
Copy link
Contributor Author

mhuggins commented Aug 1, 2018

You beat me to the punch. Thanks so much @gaearon and @philipp-spiess!

segoddnja pushed a commit to segoddnja/react that referenced this issue Aug 1, 2018
Fixes facebook#13299

Adds Electrons <webview> tag to the attribute whitelist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants