-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning: The tag <webview> is unrecognized in this browser #13299
Comments
What other special tags does Electron have? |
Looking through their docs it seems to be only the |
In that case I don’t mind adding it to the whitelist. Send a PR? |
philipp-spiess
added a commit
to philipp-spiess/react
that referenced
this issue
Aug 1, 2018
Fixes facebook#13299 Adds Electrons <webview> tag to the attribute whitelist.
gaearon
pushed a commit
that referenced
this issue
Aug 1, 2018
Fixes #13299 Adds Electrons <webview> tag to the attribute whitelist.
You beat me to the punch. Thanks so much @gaearon and @philipp-spiess! |
segoddnja
pushed a commit
to segoddnja/react
that referenced
this issue
Aug 1, 2018
Fixes facebook#13299 Adds Electrons <webview> tag to the attribute whitelist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Bug (for electron users)
What is the current behavior?
When running jest, if any components containing a webview element are rendered, a warning is rendered to the console. When many tests are run, the output is littered with warnings.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:
https://jsfiddle.net/Luktwrdm/859/
What is the expected behavior?
No warning is logged to the console.
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React: 16.4.1
Electron: 2.0.6
Unknown if it worked in prior versions of react.
The text was updated successfully, but these errors were encountered: