Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for rAF polyfill lazily #11114

Closed
gaearon opened this issue Oct 5, 2017 · 2 comments
Closed

Check for rAF polyfill lazily #11114

gaearon opened this issue Oct 5, 2017 · 2 comments
Labels
Component: DOM Type: Enhancement

Comments

@gaearon
Copy link
Collaborator

gaearon commented Oct 5, 2017

Cases like facebook/create-react-app#3199 (comment) can be pretty confusing. We should probably move the warning to happen during first ReactDOM.render rather than immediately.
@jquense jquense mentioned this issue Oct 5, 2017
Closed
jquense added a commit that referenced this issue Oct 5, 2017
@jquense
Move RAF check to first render()
793a87e 
fixes #11114
@gaearon
Copy link
Collaborator Author

gaearon commented Oct 31, 2017

See #11117 (review).

@gaearon gaearon closed this as completed Oct 31, 2017
@jovanliuc
Copy link

That's cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: DOM Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move RAF check to first render() facebook/react
2 participants
@gaearon @jovanliuc