Skip to content

Commit

Permalink
[Fizz] Client render the nearest child or parent suspense boundary if…
Browse files Browse the repository at this point in the history
… replay errors or is aborted (#27386)

Based on #27385.

When we error or abort during replay, that doesn't actually error the
component that errored because that has already rendered. The error only
affects any child that is not yet completed. Therefore the error kind of
gets thrown at the resumable point.

The resumable point might be a hole in the replay path, in which case
throwing there errors the parent boundary just the same as if the replay
component errored. If the hole is inside a deeper Suspense boundary
though, then it's that Suspense boundary that gets client rendered. I.e.
the child boundary. We can still finish any siblings.

In the shell all resumable points are inside a boundary since we must
have finished the shell. Therefore if you error in the root, we just
simply just turn all incomplete boundaries into client renders.

DiffTrain build for [925c66a](925c66a)
  • Loading branch information
sebmarkbage committed Sep 18, 2023
1 parent 8eacd9a commit efe6360
Show file tree
Hide file tree
Showing 8 changed files with 1,729 additions and 645 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
df061b396644bb7c27ea76bb27ae09784ce6444b
925c66a6472a61e7174dabf6c697a9a320ebc170
Loading

0 comments on commit efe6360

Please sign in to comment.